Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2846763005: Revert of Add missing headers to framework umbrella header. (Closed)

Created:
3 years, 7 months ago by hewwatt
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add missing headers to framework umbrella header. (patchset #3 id:40001 of https://codereview.webrtc.org/2832803002/ ) Reason for revert: this should be reported in different issue Original issue's description: > This CL adds RTCMTLVideoView.h and RTCCameraVideoCapturer.h to WebRTC.h > in order to fix a build issue that comes up when using WebRTC.framework from swift code. > > BUG=webrtc:7488 > > Review-Url: https://codereview.webrtc.org/2832803002 > Cr-Commit-Position: refs/heads/master@{#17909} > Committed: https://chromium.googlesource.com/external/webrtc/+/ace5c8836d23dda287fe1232f94c7c3192408ddd TBR=kthelgason@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/examples/objc/AppRTCMobile/ios/ARDVideoCallViewController.m View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
hewwatt
Created Revert of Add missing headers to framework umbrella header.
3 years, 7 months ago (2017-04-28 06:57:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2846763005/1
3 years, 7 months ago (2017-04-28 06:57:11 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 06:57:13 UTC) #5
No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698