Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Issue 2832803002: Add missing headers to framework umbrella header. (Closed)

Created:
3 years, 8 months ago by hewwatt
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

This CL adds RTCMTLVideoView.h and RTCCameraVideoCapturer.h to WebRTC.h in order to fix a build issue that comes up when using WebRTC.framework from swift code. BUG=webrtc:7488 Review-Url: https://codereview.webrtc.org/2832803002 Cr-Commit-Position: refs/heads/master@{#17909} Committed: https://chromium.googlesource.com/external/webrtc/+/ace5c8836d23dda287fe1232f94c7c3192408ddd

Patch Set 1 #

Patch Set 2 : move author info to the end of individual contributors list BUG=webrtc:7488 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/WebRTC.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
hewwatt
email address in AUTHORS as requested
3 years, 8 months ago (2017-04-20 12:45:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2832803002/20001
3 years, 8 months ago (2017-04-21 17:47:06 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-21 17:47:07 UTC) #13
kthelgason
+magjed for owner. this lgtm.
3 years, 8 months ago (2017-04-26 13:04:34 UTC) #15
magjed_webrtc
lgtm
3 years, 8 months ago (2017-04-26 13:15:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2832803002/20001
3 years, 7 months ago (2017-04-27 12:58:21 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/ace5c8836d23dda287fe1232f94c7c3192408ddd
3 years, 7 months ago (2017-04-27 13:26:24 UTC) #21
hewwatt
3 years, 7 months ago (2017-04-28 06:57:01 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2846763005/ by hewwatt@gmail.com.

The reason for reverting is: this should be reported in different issue.

Powered by Google App Engine
This is Rietveld 408576698