Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2844803003: Have AudioSendStream register CNG payload types with the RtpRtcpModule. (Closed)

Created:
3 years, 7 months ago by ossu
Modified:
3 years, 7 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, tlegrand-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Have AudioSendStream register CNG payload types with the RtpRtcpModule. TBR=kwiberg@webrtc.org # Turn perf-bots green again BUG=webrtc:5806 Review-Url: https://codereview.webrtc.org/2844803003 Cr-Commit-Position: refs/heads/master@{#17911} Committed: https://chromium.googlesource.com/external/webrtc/+/3b9ff38d8a10d46f69680c5634b4814fb02378e2

Patch Set 1 #

Patch Set 2 : Add mocks for GetRtpRtcp in AudioSendStreamTest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M webrtc/audio/audio_send_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 4 chunks +29 lines, -1 line 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (13 generated)
ossu
PTAL. The problem it fixes is turning some of our bots red, so I'll be ...
3 years, 7 months ago (2017-04-27 14:44:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2844803003/20001
3 years, 7 months ago (2017-04-27 15:00:53 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 15:03:47 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/3b9ff38d8a10d46f69680c563...

Powered by Google App Engine
This is Rietveld 408576698