Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2844433002: Delete declaration of non-existing function webrtc::Version(). (Closed)

Created:
3 years, 8 months ago by nisse-webrtc
Modified:
3 years, 8 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete declaration of non-existing function webrtc::Version(). BUG=None Review-Url: https://codereview.webrtc.org/2844433002 Cr-Commit-Position: refs/heads/master@{#17862} Committed: https://chromium.googlesource.com/external/webrtc/+/b8a654c218f1bb6859f2eabf103b09454e4803b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/call/call.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nisse-webrtc
I'm afraid I have little clue about what this function was used for, if anything. ...
3 years, 8 months ago (2017-04-25 09:43:49 UTC) #2
the sun
lgtm
3 years, 8 months ago (2017-04-25 09:57:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2844433002/1
3 years, 8 months ago (2017-04-25 10:19:34 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 10:46:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b8a654c218f1bb6859f2eabf1...

Powered by Google App Engine
This is Rietveld 408576698