Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2844283002: Add NetEqInput::PacketData::ToString method (Closed)

Created:
3 years, 7 months ago by hlundin-webrtc
Modified:
3 years, 7 months ago
Reviewers:
*ivoc, AleBzk
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add NetEqInput::PacketData::ToString method This new method prints information about the packet. BUG=webrtc:7467 Review-Url: https://codereview.webrtc.org/2844283002 Cr-Commit-Position: refs/heads/master@{#17922} Committed: https://chromium.googlesource.com/external/webrtc/+/7a38fd2628eb6711a9adae9ce93b41c85f1521b0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_input.h View 2 chunks +3 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/neteq/tools/neteq_input.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_test.cc View 1 chunk +1 line, -5 lines 2 comments Download

Depends on Patchset:

Issue 2845013003 Patch 40001

Dependent Patchsets:

Issue 2851383004 Patch 1

Messages

Total messages: 10 (5 generated)
hlundin-webrtc
PTAL https://codereview.webrtc.org/2844283002/diff/1/webrtc/modules/audio_coding/neteq/tools/neteq_test.cc File webrtc/modules/audio_coding/neteq/tools/neteq_test.cc (right): https://codereview.webrtc.org/2844283002/diff/1/webrtc/modules/audio_coding/neteq/tools/neteq_test.cc#newcode30 webrtc/modules/audio_coding/neteq/tools/neteq_test.cc:30: std::cerr << "Packet data: " << packet.ToString() << ...
3 years, 7 months ago (2017-04-27 13:21:07 UTC) #3
AleBzk
lgtm https://codereview.webrtc.org/2844283002/diff/1/webrtc/modules/audio_coding/neteq/tools/neteq_test.cc File webrtc/modules/audio_coding/neteq/tools/neteq_test.cc (right): https://codereview.webrtc.org/2844283002/diff/1/webrtc/modules/audio_coding/neteq/tools/neteq_test.cc#newcode30 webrtc/modules/audio_coding/neteq/tools/neteq_test.cc:30: std::cerr << "Packet data: " << packet.ToString() << ...
3 years, 7 months ago (2017-04-27 13:27:00 UTC) #4
ivoc
lgtm.
3 years, 7 months ago (2017-04-27 15:20:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2844283002/1
3 years, 7 months ago (2017-04-28 08:09:44 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 08:35:57 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7a38fd2628eb6711a9adae9ce...

Powered by Google App Engine
This is Rietveld 408576698