Don't display colors on gtest-parallel logs on swarming.

Don't display colors on gtest-parallel logs on swarming.

It makes the logs hard to read, and swarming doesn't output colors anyway.

Also:
- Fix a bug where we tried to access output_dir when combining the logs even if the flag was not set.
- Update a comment explaining why we just 'eat' the --isolated-script-test-chartjson-output flag.

NOTRY=True
BUG=webrtc:7524
Review-Url: https://codereview.webrtc.org/2843263005
Cr-Commit-Position: refs/heads/master@{#17973}
Committed: https://chromium.googlesource.com/external/webrtc/+/950614eb0c9feb60648ce3c074a5ea417e4e0113

[ehmaldonado_webrtc, 2017-04-28 10:32:39]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ehmaldonado_webrtc, 2017-04-28 10:32:39]

https://codereview.webrtc.org/2843263005/diff/1/tools-webrtc/gtest-parallel-w...
File tools-webrtc/gtest-parallel-wrapper.py (right):

https://codereview.webrtc.org/2843263005/diff/1/tools-webrtc/gtest-parallel-w...
tools-webrtc/gtest-parallel-wrapper.py:65:
parser.add_argument('--isolated-script-test-chartjson-output', type=str,
Not related to this CL, but I think we don't need to implement it (and possibly
even can't), since it is meant for telemetry tests output.

https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[kjellander_webrtc, 2017-04-28 10:59:38]

Does this entirely fix https://bugs.chromium.org/p/webrtc/issues/detail?id=7524
or it just addresses the color part mentioned in there?

https://codereview.webrtc.org/2843263005/diff/1/tools-webrtc/gtest-parallel-w...
File tools-webrtc/gtest-parallel-wrapper.py (right):

https://codereview.webrtc.org/2843263005/diff/1/tools-webrtc/gtest-parallel-w...
tools-webrtc/gtest-parallel-wrapper.py:65:
parser.add_argument('--isolated-script-test-chartjson-output', type=str,
On 2017/04/28 10:32:39, ehmaldonado_webrtc wrote:
> Not related to this CL, but I think we don't need to implement it (and
possibly
> even can't), since it is meant for telemetry tests output.
> 
>
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
> 

I see, can you update the comment to mention the above then? And remove the
TODO.

https://codereview.webrtc.org/2843263005/diff/1/tools-webrtc/gtest-parallel-w...
tools-webrtc/gtest-parallel-wrapper.py:70: parser.add_argument('--gtest_color',
type=str, default='yes')
What about having 'auto' as the default, since it seems to be the default for
gtest executables?

https://codereview.webrtc.org/2843263005/diff/1/tools-webrtc/gtest-parallel-w...
tools-webrtc/gtest-parallel-wrapper.py:130: if options.output_dir:
if this is a bugfix, can you mention it in the CL description as well?

[ehmaldonado_webrtc, 2017-04-28 11:16:46]

Description was changed from

==========
Don't display colors on gtest-parallel logs on swarming.

It makes the logs hard to read, and swarming doesn't output colors anyway.

BUG=webrtc:7524
==========

to

==========
Don't display colors on gtest-parallel logs on swarming.

It makes the logs hard to read, and swarming doesn't output colors anyway.

Also:
- Fix a bug where we tried to access output_dir when combining the logs even if
the flag was not set.
- Update a comment explaining why we just 'eat' the
--isolated-script-test-chartjson-output flag.

BUG=webrtc:7524
==========

[ehmaldonado_webrtc, 2017-04-28 11:17:52]

This just fixes the color issue.
The other issues where failed tests ended up in the passed logs should've been
fixed with the gtest-parallel pull request.

[kjellander_webrtc, 2017-05-02 11:48:08]

lgtm

[ehmaldonado_webrtc, 2017-05-02 11:49:38]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 11:49:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-02 12:30:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 12:30:52]

Dry run: This issue passed the CQ dry run.

[ehmaldonado_webrtc, 2017-05-02 12:49:51]

Description was changed from

==========
Don't display colors on gtest-parallel logs on swarming.

It makes the logs hard to read, and swarming doesn't output colors anyway.

Also:
- Fix a bug where we tried to access output_dir when combining the logs even if
the flag was not set.
- Update a comment explaining why we just 'eat' the
--isolated-script-test-chartjson-output flag.

BUG=webrtc:7524
==========

to

==========
Don't display colors on gtest-parallel logs on swarming.

It makes the logs hard to read, and swarming doesn't output colors anyway.

Also:
- Fix a bug where we tried to access output_dir when combining the logs even if
the flag was not set.
- Update a comment explaining why we just 'eat' the
--isolated-script-test-chartjson-output flag.

NOTRY=True
BUG=webrtc:7524
==========

[ehmaldonado_webrtc, 2017-05-02 12:49:57]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-05-02 12:50:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-02 12:52:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493729397913410,
"parent_rev": "3c1e558449309be965815e1bf67d2391500343ce", "commit_rev":
"950614eb0c9feb60648ce3c074a5ea417e4e0113"}

[commit-bot: I haz the power, 2017-05-02 12:53:02]

Description was changed from

==========
Don't display colors on gtest-parallel logs on swarming.

It makes the logs hard to read, and swarming doesn't output colors anyway.

Also:
- Fix a bug where we tried to access output_dir when combining the logs even if
the flag was not set.
- Update a comment explaining why we just 'eat' the
--isolated-script-test-chartjson-output flag.

NOTRY=True
BUG=webrtc:7524
==========

to

==========
Don't display colors on gtest-parallel logs on swarming.

It makes the logs hard to read, and swarming doesn't output colors anyway.

Also:
- Fix a bug where we tried to access output_dir when combining the logs even if
the flag was not set.
- Update a comment explaining why we just 'eat' the
--isolated-script-test-chartjson-output flag.

NOTRY=True
BUG=webrtc:7524

Review-Url: https://codereview.webrtc.org/2843263005
Cr-Commit-Position: refs/heads/master@{#17973}
Committed:
https://chromium.googlesource.com/external/webrtc/+/950614eb0c9feb60648ce3c07...
==========

[commit-bot: I haz the power, 2017-05-02 12:53:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/950614eb0c9feb60648ce3c07...