Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2843003002: Fix redirecting to local AppRTC server in video quality test (Closed)

Created:
3 years, 8 months ago by oprypin_webrtc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, kjellander_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix redirecting to local AppRTC server in video quality test BUG=webrtc:7185 Review-Url: https://codereview.webrtc.org/2843003002 Cr-Commit-Position: refs/heads/master@{#17888} Committed: https://chromium.googlesource.com/external/webrtc/+/2e79958c42154fef56ba165b154f04ec2ca4e705

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/examples/androidtests/src/org/appspot/apprtc/test/CallActivityStubbedInputOutputTest.java View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 12 (7 generated)
oprypin_webrtc
https://codereview.webrtc.org/2843003002/diff/1/webrtc/examples/androidtests/src/org/appspot/apprtc/test/CallActivityStubbedInputOutputTest.java File webrtc/examples/androidtests/src/org/appspot/apprtc/test/CallActivityStubbedInputOutputTest.java (left): https://codereview.webrtc.org/2843003002/diff/1/webrtc/examples/androidtests/src/org/appspot/apprtc/test/CallActivityStubbedInputOutputTest.java#oldcode62 webrtc/examples/androidtests/src/org/appspot/apprtc/test/CallActivityStubbedInputOutputTest.java:62: "wstls=false?debug=loopback?ts=?wshpp=http://localhost:8089"); In the previous CL I said that this ...
3 years, 8 months ago (2017-04-26 13:06:46 UTC) #3
magjed_webrtc
lgtm
3 years, 8 months ago (2017-04-26 13:17:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2843003002/1
3 years, 8 months ago (2017-04-26 13:23:27 UTC) #6
kjellander_webrtc
lgtm, nice finding!
3 years, 8 months ago (2017-04-26 13:28:14 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 13:52:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/2e79958c42154fef56ba165b1...

Powered by Google App Engine
This is Rietveld 408576698