Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2842133002: Reject re-inserting already decoded frames into FrameBuffer2. (Closed)

Created:
3 years, 8 months ago by philipel
Modified:
3 years, 7 months ago
Reviewers:
stefan-webrtc, Stefan
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, mflodman, brandtr
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reject re-inserting already decoded frames into FrameBuffer2. BUG=webrtc:7518 Review-Url: https://codereview.webrtc.org/2842133002 Cr-Commit-Position: refs/heads/master@{#17925} Committed: https://chromium.googlesource.com/external/webrtc/+/f68426954154918ec5bf7e6b3096fa3d7acb0944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M webrtc/modules/video_coding/frame_buffer2.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/frame_buffer2_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
philipel
3 years, 8 months ago (2017-04-26 11:07:45 UTC) #2
Stefan
lgtm
3 years, 7 months ago (2017-04-28 09:43:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2842133002/1
3 years, 7 months ago (2017-04-28 09:44:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16540)
3 years, 7 months ago (2017-04-28 09:49:40 UTC) #8
stefan-webrtc
lgtm
3 years, 7 months ago (2017-04-28 09:50:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2842133002/1
3 years, 7 months ago (2017-04-28 09:51:20 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 10:29:20 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f68426954154918ec5bf7e6b3...

Powered by Google App Engine
This is Rietveld 408576698