Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2841873002: Creating webrtc:video_stream_api (Closed)

Created:
3 years, 8 months ago by mbonadei
Modified:
3 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Creating webrtc:video_stream_api This target keeps track of .h the files under webrtc/ that are not part of any target. If a .h file is not part of a target the 'gn check' utility is not able to spot if a target is missing a dependency because even if it parses '#include' directives it is not able to find a target that contains these headers. BUG=webrtc:7512 NOTRY=True Review-Url: https://codereview.webrtc.org/2841873002 Cr-Commit-Position: refs/heads/master@{#17874} Committed: https://chromium.googlesource.com/external/webrtc/+/81c79f51aa842e0c8254ebd4e91dfb0cea7c181e

Patch Set 1 #

Patch Set 2 : Build webrtc:video_stream_api also with chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/call/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/tools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mbonadei
3 years, 8 months ago (2017-04-25 13:26:47 UTC) #2
kjellander_webrtc
lgtm I fired the linux_libfuzzer_rel trybot for you :)
3 years, 8 months ago (2017-04-25 20:15:56 UTC) #3
mbonadei
On 2017/04/25 20:15:56, kjellander_webrtc wrote: > lgtm > I fired the linux_libfuzzer_rel trybot for you ...
3 years, 8 months ago (2017-04-26 06:39:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2841873002/20001
3 years, 8 months ago (2017-04-26 06:39:44 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 06:42:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/81c79f51aa842e0c8254ebd4e...

Powered by Google App Engine
This is Rietveld 408576698