Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Unified Diff: webrtc/pc/rtcstats_integrationtest.cc

Issue 2840833002: Delete media type check in Call::NotifyBweOfReceivedPacket.
Patch Set: Comment update. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/call/call.cc ('K') | « webrtc/call/call.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/rtcstats_integrationtest.cc
diff --git a/webrtc/pc/rtcstats_integrationtest.cc b/webrtc/pc/rtcstats_integrationtest.cc
index a2bfb3ee6a8bd12b42285d02bcee0279b458e8ff..edb91d329e4761587bda4a6cc0df071f03ac6bd3 100644
--- a/webrtc/pc/rtcstats_integrationtest.cc
+++ b/webrtc/pc/rtcstats_integrationtest.cc
@@ -139,6 +139,15 @@ class RTCStatsVerifier {
}
template<typename T>
+ void TestMemberIsUndefinedOrNonNegative(
+ const RTCStatsMemberInterface& member) {
+ if (member.is_defined())
+ TestMemberIsNonNegative<T>(member);
+ else
+ MarkMemberTested(member, true);
+ }
+
+ template<typename T>
void TestMemberIsPositive(const RTCStatsMemberInterface& member) {
EXPECT_TRUE(member.is_defined()) <<
stats_->type() << "." << member.name() << "[" << stats_->id() <<
@@ -384,10 +393,15 @@ class RTCStatsReportVerifier {
if (is_selected_pair) {
verifier.TestMemberIsNonNegative<double>(
candidate_pair.available_outgoing_bitrate);
+ // TODO(hbos, nisse): It's usually undefined, but have appeared in tests
+ // on the tsan try-bot. Find out why, possibly something timing related?
+ // See https://bugs.webrtc.org/7062.
+ verifier.TestMemberIsUndefinedOrNonNegative<double>(
+ candidate_pair.available_incoming_bitrate);
} else {
verifier.TestMemberIsUndefined(candidate_pair.available_outgoing_bitrate);
+ verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate);
}
- verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate);
verifier.TestMemberIsNonNegative<uint64_t>(
candidate_pair.requests_received);
verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.requests_sent);
« webrtc/call/call.cc ('K') | « webrtc/call/call.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698