Delete media type check in Call::NotifyBweOfReceivedPacket.

webrtc/pc/rtcstats_integrationtest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 121 matching lines @@
   }
 
   void TestMemberIsUndefined(const RTCStatsMemberInterface& member) {
     EXPECT_FALSE(member.is_defined()) <<
         stats_->type() << "." << member.name() << "[" << stats_->id() <<
         "] was defined (" << member.ValueToString() << ").";
     MarkMemberTested(member, !member.is_defined());
   }
 
   template<typename T>
+  void TestMemberIsUndefinedOrNonNegative(
+      const RTCStatsMemberInterface& member) {
+    if (member.is_defined())
+      TestMemberIsNonNegative<T>(member);
+    else
+      MarkMemberTested(member, true);
+  }
+
+  template<typename T>
   void TestMemberIsPositive(const RTCStatsMemberInterface& member) {
     EXPECT_TRUE(member.is_defined()) <<
         stats_->type() << "." << member.name() << "[" << stats_->id() <<
         "] was undefined.";
     if (!member.is_defined()) {
       MarkMemberTested(member, false);
       return;
     }
     bool is_positive = *member.cast_to<RTCStatsMember<T>>() > T(0);
     EXPECT_TRUE(is_positive) <<
@@ skipping 225 matching lines @@
     verifier.TestMemberIsUndefined(candidate_pair.readable);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.bytes_sent);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.bytes_received);
     verifier.TestMemberIsNonNegative<double>(
         candidate_pair.total_round_trip_time);
     verifier.TestMemberIsNonNegative<double>(
         candidate_pair.current_round_trip_time);
     if (is_selected_pair) {
       verifier.TestMemberIsNonNegative<double>(
           candidate_pair.available_outgoing_bitrate);
+      // TODO(hbos, nisse): It's usually undefined, but have appeared in tests
+      // on the tsan try-bot. Find out why, possibly something timing related?
+      // See https://bugs.webrtc.org/7062.
+      verifier.TestMemberIsUndefinedOrNonNegative<double>(
+          candidate_pair.available_incoming_bitrate);
     } else {
       verifier.TestMemberIsUndefined(candidate_pair.available_outgoing_bitrate);
+      verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate);
     }
-    verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate);
     verifier.TestMemberIsNonNegative<uint64_t>(
         candidate_pair.requests_received);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.requests_sent);
     verifier.TestMemberIsNonNegative<uint64_t>(
         candidate_pair.responses_received);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.responses_sent);
     verifier.TestMemberIsUndefined(candidate_pair.retransmissions_received);
     verifier.TestMemberIsUndefined(candidate_pair.retransmissions_sent);
     verifier.TestMemberIsUndefined(candidate_pair.consent_requests_received);
     verifier.TestMemberIsNonNegative<uint64_t>(
@@ skipping 245 matching lines @@
   caller_ = nullptr;
   // Any pending stats requests should have completed in the act of destroying
   // the peer connection.
   EXPECT_TRUE(stats_obtainer->report());
 }
 #endif  // HAVE_SCTP
 
 }  // namespace
 
 }  // namespace webrtc