Implementation of new AecDump interface.

Implementation of new AecDump interface.

[WORK IN PROGRESS, DO NOT SUBMIT]

[TODO WRITE DESCRIPTION, elaborate]

This CL contains the implementation and tests of the AecDump
interface, defined in the parent CL. There will be a further CL that
adds a top-level task queue and activates the new AecDump instead of
the current functionality.

[TODO ADD TESTS without removing existing ones]

BUG=webrtc:7404

[aleloi, 2017-04-25 14:36:14]

Description was changed from

==========
Implementation of new AecDump interface.

[WORK IN PROGRESS, DO NOT SUBMIT]

[TODO WRITE DESCRIPTION, elaborate]

This CL contains the implementation and tests of the AecDump
interface, defined in the parent CL. There will be a further CL that
adds a top-level task queue and activates the new AecDump instead of
the current functionality.

BUG=webrtc:7404
==========

to

==========
Implementation of new AecDump interface.

[WORK IN PROGRESS, DO NOT SUBMIT]

[TODO WRITE DESCRIPTION, elaborate]

This CL contains the implementation and tests of the AecDump
interface, defined in the parent CL. There will be a further CL that
adds a top-level task queue and activates the new AecDump instead of
the current functionality.

BUG=webrtc:7404
==========

[aleloi, 2017-04-26 09:20:57]

Description was changed from

==========
Implementation of new AecDump interface.

[WORK IN PROGRESS, DO NOT SUBMIT]

[TODO WRITE DESCRIPTION, elaborate]

This CL contains the implementation and tests of the AecDump
interface, defined in the parent CL. There will be a further CL that
adds a top-level task queue and activates the new AecDump instead of
the current functionality.

BUG=webrtc:7404
==========

to

==========
Implementation of new AecDump interface.

[WORK IN PROGRESS, DO NOT SUBMIT]

[TODO WRITE DESCRIPTION, elaborate]

This CL contains the implementation and tests of the AecDump
interface, defined in the parent CL. There will be a further CL that
adds a top-level task queue and activates the new AecDump instead of
the current functionality.

[TODO ADD TESTS without removing existing ones]

BUG=webrtc:7404
==========

[aleloi, 2017-04-26 11:21:04]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2017-05-04 14:40:31]

peah@webrtc.org changed reviewers:
+ peah@webrtc.org

[peah-webrtc, 2017-05-04 14:40:32]

drive-by comments

https://codereview.webrtc.org/2838133003/diff/120001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/aec_dump/aec_dump_impl.cc (right):

https://codereview.webrtc.org/2838133003/diff/120001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/aec_dump/aec_dump_impl.cc:215: auto event =
std::unique_ptr<audioproc::Event>(new audioproc::Event());
Is it possible to have event being a part of WriteToFileTask? As it is now, you
need to new-up 2 object for each store.

https://codereview.webrtc.org/2838133003/diff/120001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/aec_dump/aec_dump_impl.cc:233:
worker_queue_->PostTask(std::unique_ptr<rtc::QueuedTask>(new WriteToFileTask(
Is it needed to create a new task here? Can't we reuse a task?

[aleloi, 2017-05-12 12:50:59]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 12:51:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-12 12:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 12:53:12]

Dry run: Try jobs failed on following builders:
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/20239)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/21433)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/25590)

[aleloi, 2017-05-12 12:58:19]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 12:58:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-12 13:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 13:18:12]

Dry run: Try jobs failed on following builders:
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/8964)