Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: webrtc/modules/audio_processing/include/aec_dump.h

Issue 2838133003: Implementation of new AecDump interface. (Closed)
Patch Set: Changed CaptureStreamInfo behaviour. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_processing/include/aec_dump.h
diff --git a/webrtc/modules/audio_processing/include/aec_dump.h b/webrtc/modules/audio_processing/include/aec_dump.h
index 3391924dc94ccfe858426974d129869423030743..68d50d0490502ec3da6ccebf99c93cc736ba6d92 100644
--- a/webrtc/modules/audio_processing/include/aec_dump.h
+++ b/webrtc/modules/audio_processing/include/aec_dump.h
@@ -103,8 +103,9 @@ class AecDump {
// instance is first filled with Input, then Output.
//
// To log an input/output pair, first call
- // AecDump::GetCaptureStreamInfo. Add the input and output to
- // it. Then call AecDump::WriteCaptureStreamMessage.
+ // AecDump::GetCaptureStreamInfo. Add the input and output to the
+ // returned CaptureStreamInfo pointer. Then call
+ // AecDump::WriteCaptureStreamMessage.
class CaptureStreamInfo {
public:
virtual ~CaptureStreamInfo() = default;
@@ -122,8 +123,7 @@ class AecDump {
virtual ~AecDump() = default;
- virtual std::unique_ptr<CaptureStreamInfo> CreateCaptureStreamInfo()
- const = 0;
+ virtual CaptureStreamInfo* GetCaptureStreamInfo() = 0;
// The Write* methods are always safe to call concurrently or
// otherwise for all implementing subclasses. The intended mode of
@@ -136,8 +136,7 @@ class AecDump {
virtual void WriteRenderStreamMessage(const FloatAudioFrame& src) = 0;
- virtual void WriteCaptureStreamMessage(
- std::unique_ptr<CaptureStreamInfo> stream_info) = 0;
+ virtual void WriteCaptureStreamMessage() = 0;
// If not |forced|, only writes the current config if it is
// different from the last saved one; if |forced|, writes the config
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698