Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2835963002: Check if the order of frames becomes ambiguous if we were to insert the incoming frame, and if so, … (Closed)

Created:
3 years, 8 months ago by philipel
Modified:
3 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/branch-heads/59
Project:
webrtc
Visibility:
Public.

Description

Check if the order of frames becomes ambiguous if we were to insert the incoming frame, and if so, clear the FrameBuffer. BUG=chromium:679306 Review-Url: https://codereview.webrtc.org/2830723002 Cr-Commit-Position: refs/heads/master@{#17785} (cherry picked from commit 146a48b0fabef7e74f2a2b62fb5cb45f9b393408) Landed here: https://chromium.googlesource.com/external/webrtc/+/6d56d2ebf0e40bc73dee99093ac7c223ddc7b6e5 But the CL was not updated for some reason.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M webrtc/modules/video_coding/frame_buffer2.cc View 2 chunks +13 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/frame_buffer2_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
philipel
Merge to M59
3 years, 8 months ago (2017-04-24 08:55:14 UTC) #2
stefan-webrtc
lgtm
3 years, 8 months ago (2017-04-24 08:56:18 UTC) #3
philipel
3 years, 8 months ago (2017-04-24 09:30:21 UTC) #4
Message was sent while issue was closed.
Landed here:
https://chromium.googlesource.com/external/webrtc/+/6d56d2ebf0e40bc73dee99093...
but the CL was not updated for some reason

Powered by Google App Engine
This is Rietveld 408576698