Check if the order of frames becomes ambiguous by inserting a new frame, and if so, clear the Frame…

Check if the order of frames becomes ambiguous if we were to insert the incoming frame, and if so, clear the FrameBuffer.

BUG=chromium:679306
Review-Url: https://codereview.webrtc.org/2830723002
Cr-Commit-Position: refs/heads/master@{#17785}
Committed: https://chromium.googlesource.com/external/webrtc/+/146a48b0fabef7e74f2a2b62fb5cb45f9b393408

[philipel, 2017-04-19 16:45:02]

philipel@webrtc.org changed reviewers:
+ holmer@chromium.org

[philipel, 2017-04-19 17:14:35]

The CQ bit was checked by philipel@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 17:14:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[philipel, 2017-04-19 17:15:22]

Description was changed from

==========
Check if the order of frames becoms ambiguous by inserting a new frame, and if
so, clear the FrameBuffer.

BUG=chrome:679306
==========

to

==========
Check if the order of frames becomes ambiguous if we were to insert the incoming
frame, and if so, clear the FrameBuffer.

BUG=chrome:679306
==========

[commit-bot: I haz the power, 2017-04-19 17:35:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 17:35:32]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2017-04-20 09:36:46]

stefan@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2017-04-20 09:36:47]

https://codereview.webrtc.org/2830723002/diff/1/webrtc/modules/video_coding/f...
File webrtc/modules/video_coding/frame_buffer2.cc (right):

https://codereview.webrtc.org/2830723002/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_buffer2.cc:96: for (; frame_it !=
continuous_end_it; ++frame_it) {
Add a check that continuous_end_it is larger than or equal to frame_it

[philipel, 2017-04-20 09:42:27]

Patchset #2 (id:20001) has been deleted

[stefan-webrtc, 2017-04-20 10:41:06]

Description was changed from

==========
Check if the order of frames becomes ambiguous if we were to insert the incoming
frame, and if so, clear the FrameBuffer.

BUG=chrome:679306
==========

to

==========
Check if the order of frames becomes ambiguous if we were to insert the incoming
frame, and if so, clear the FrameBuffer.

BUG=chromium:679306
==========

[stefan-webrtc, 2017-04-20 10:41:32]

lgtm

[philipel, 2017-04-20 10:44:20]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2017-04-20 10:44:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-20 11:04:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492685060029650,
"parent_rev": "7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc", "commit_rev":
"146a48b0fabef7e74f2a2b62fb5cb45f9b393408"}

[commit-bot: I haz the power, 2017-04-20 11:04:42]

Description was changed from

==========
Check if the order of frames becomes ambiguous if we were to insert the incoming
frame, and if so, clear the FrameBuffer.

BUG=chromium:679306
==========

to

==========
Check if the order of frames becomes ambiguous if we were to insert the incoming
frame, and if so, clear the FrameBuffer.

BUG=chromium:679306

Review-Url: https://codereview.webrtc.org/2830723002
Cr-Commit-Position: refs/heads/master@{#17785}
Committed:
https://chromium.googlesource.com/external/webrtc/+/146a48b0fabef7e74f2a2b62f...
==========

[commit-bot: I haz the power, 2017-04-20 11:04:43]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/146a48b0fabef7e74f2a2b62f...