Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2835893003: Delete unused class ComThread. (Closed)

Created:
3 years, 8 months ago by nisse-webrtc
Modified:
3 years, 8 months ago
Reviewers:
tommi, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, tommi
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused class ComThread. BUG=None Review-Url: https://codereview.webrtc.org/2835893003 Cr-Commit-Position: refs/heads/master@{#17857} Committed: https://chromium.googlesource.com/external/webrtc/+/30cba07bd11cd5475550488a1b58404d7779cb93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -64 lines) Patch
M webrtc/base/thread.h View 1 chunk +0 lines, -15 lines 0 comments Download
M webrtc/base/thread.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/base/thread_unittest.cc View 2 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
nisse-webrtc
While working on other changes touching thread.cc, I noticed this class, which appears unused. Ok ...
3 years, 8 months ago (2017-04-24 09:50:39 UTC) #2
tommi
lgtm
3 years, 8 months ago (2017-04-24 09:52:54 UTC) #4
pthatcher1
lgtm
3 years, 8 months ago (2017-04-24 22:46:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2835893003/1
3 years, 8 months ago (2017-04-25 06:38:00 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 07:09:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/30cba07bd11cd5475550488a1...

Powered by Google App Engine
This is Rietveld 408576698