webrtc/modules/congestion_controller/include/send_side_congestion_controller.h - Issue 2834663003: Allow mocking SendSideCongestionController for Call tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

Issue 2834663003: Allow mocking SendSideCongestionController for Call tests. (Closed)

Patch Set: Add MockSendSideCongestionController constructor Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/congestion_controller/include/mock/mock_send_side_congestion_controller.h ('K') | « webrtc/modules/congestion_controller/include/mock/mock_send_side_congestion_controller.h ('k') | webrtc/modules/congestion_controller/send_side_congestion_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

diff --git a/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h b/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

index 66bcb314d2665760ac4d7b660dcbcc2e467ffef4..41ee3be612d2d388260cf415c5dcdf9697b775fe 100644

--- a/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

+++ b/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

@@ -57,13 +57,10 @@ class SendSideCongestionController : public CallStatsObserver,

protected:

virtual ~Observer() {}

};

- // TODO(nisse): Consider deleting the |observer| argument to constructors.

nisse-webrtc 2017/04/26 07:37:14 I'm afraid this has to wait until the old Congesti

Zach Stein 2017/04/26 20:39:53 I'll see what I can get working without this chang

SendSideCongestionController(const Clock* clock,

- Observer* observer,

RtcEventLog* event_log,

PacketRouter* packet_router);

SendSideCongestionController(const Clock* clock,

- Observer* observer,

RtcEventLog* event_log,

std::unique_ptr<PacedSender> pacer);

virtual ~SendSideCongestionController();