Chromium Code Reviews

Side by Side Diff: webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

Issue 2834663003: Allow mocking SendSideCongestionController for Call tests. (Closed)
Patch Set: Add MockSendSideCongestionController constructor Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 39 matching lines...)
50 class Observer { 50 class Observer {
51 public: 51 public:
52 virtual void OnNetworkChanged(uint32_t bitrate_bps, 52 virtual void OnNetworkChanged(uint32_t bitrate_bps,
53 uint8_t fraction_loss, // 0 - 255. 53 uint8_t fraction_loss, // 0 - 255.
54 int64_t rtt_ms, 54 int64_t rtt_ms,
55 int64_t probing_interval_ms) = 0; 55 int64_t probing_interval_ms) = 0;
56 56
57 protected: 57 protected:
58 virtual ~Observer() {} 58 virtual ~Observer() {}
59 }; 59 };
60 // TODO(nisse): Consider deleting the |observer| argument to constructors.
nisse-webrtc 2017/04/26 07:37:14 I'm afraid this has to wait until the old Congesti
Zach Stein 2017/04/26 20:39:53 I'll see what I can get working without this chang
61 SendSideCongestionController(const Clock* clock, 60 SendSideCongestionController(const Clock* clock,
62 Observer* observer,
63 RtcEventLog* event_log, 61 RtcEventLog* event_log,
64 PacketRouter* packet_router); 62 PacketRouter* packet_router);
65 SendSideCongestionController(const Clock* clock, 63 SendSideCongestionController(const Clock* clock,
66 Observer* observer,
67 RtcEventLog* event_log, 64 RtcEventLog* event_log,
68 std::unique_ptr<PacedSender> pacer); 65 std::unique_ptr<PacedSender> pacer);
69 virtual ~SendSideCongestionController(); 66 virtual ~SendSideCongestionController();
70 67
71 void RegisterPacketFeedbackObserver(PacketFeedbackObserver* observer); 68 void RegisterPacketFeedbackObserver(PacketFeedbackObserver* observer);
72 void DeRegisterPacketFeedbackObserver(PacketFeedbackObserver* observer); 69 void DeRegisterPacketFeedbackObserver(PacketFeedbackObserver* observer);
73 70
74 // Currently, there can be at most one observer. 71 // Currently, there can be at most one observer.
75 void RegisterNetworkObserver(Observer* observer); 72 void RegisterNetworkObserver(Observer* observer);
76 void DeRegisterNetworkObserver(Observer* observer); 73 void DeRegisterNetworkObserver(Observer* observer);
(...skipping 77 matching lines...)
154 std::unique_ptr<DelayBasedBwe> delay_based_bwe_ GUARDED_BY(bwe_lock_); 151 std::unique_ptr<DelayBasedBwe> delay_based_bwe_ GUARDED_BY(bwe_lock_);
155 152
156 rtc::ThreadChecker worker_thread_checker_; 153 rtc::ThreadChecker worker_thread_checker_;
157 154
158 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(SendSideCongestionController); 155 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(SendSideCongestionController);
159 }; 156 };
160 157
161 } // namespace webrtc 158 } // namespace webrtc
162 159
163 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_SEND_SIDE_CONGESTION_CON TROLLER_H_ 160 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_SEND_SIDE_CONGESTION_CON TROLLER_H_
OLDNEW

Powered by Google App Engine