Allow mocking SendSideCongestionController for Call tests.

webrtc/modules/congestion_controller/include/mock/mock_send_side_congestion_controller.h

Index: webrtc/modules/congestion_controller/include/mock/mock_send_side_congestion_controller.h
diff --git a/webrtc/modules/congestion_controller/include/mock/mock_send_side_congestion_controller.h b/webrtc/modules/congestion_controller/include/mock/mock_send_side_congestion_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..c14cff6b5b27a964ca022269b5998af3da1cbd48
--- /dev/null
+++ b/webrtc/modules/congestion_controller/include/mock/mock_send_side_congestion_controller.h
@@ -0,0 +1,37 @@
+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_MOCK_MOCK_SEND_SIDE_CONGESTION_CONTROLLER_H_
+#define WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_MOCK_MOCK_SEND_SIDE_CONGESTION_CONTROLLER_H_
+
+#include "webrtc/modules/congestion_controller/include/send_side_congestion_controller.h"
+#include "webrtc/test/gmock.h"
+
+namespace webrtc {
+namespace test {
+
+class MockSendSideCongestionController : public SendSideCongestionController {
+ public:
+  MockSendSideCongestionController(const Clock* clock,
+                                   RtcEventLog* event_log,
+                                   PacketRouter* packet_router)
+      : SendSideCongestionController(clock, event_log, packet_router)
+  {}
+
+  MOCK_METHOD3(SetBweBitrates,

[nisse-webrtc, 2017/04/26 07:37:14]

It makes some sense to me to add only mock methods that tests actually use, but
I'm not sure if that's how we usually do things? Is it common practice to mock
only one or a few methods of a large interface like this?

I've been bitten by crashes when a mock class was missing an implementation of a
certain method, and the test crashed because the other methods of the mock
object didn't set up the proper state required for the real implementation of
that method.

[Zach Stein, 2017/04/26 20:39:53]

I'm not sure what we usually do - this is my first time trying to introduce a
mock :) I just provided the minimal implementation for the tests I need.

+               void(int min_bitrate_bps,
+                    int start_bitrate_bps,
+                    int max_bitrate_bps));
+};
+
+}  // namespace test
+}  // namespace webrtc
+
+#endif  // WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_MOCK_MOCK_SEND_SIDE_CONGESTION_CONTROLLER_H_