Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2834543005: Add comments about PeerConnection::Close and PeerConnectionObserver. (Closed)

Created:
3 years, 8 months ago by Taylor Brandstetter
Modified:
3 years, 8 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add comments about PeerConnection::Close and PeerConnectionObserver. Documenting that the observer can safely be destroyed after Close has been called, because it ensures no more callbacks will be invoked. Just like in JavaScript land, where no more events will be fired after "close" is called. This is already covered by unit tests. BUG=webrtc:7491 NOTRY=True TBR=pthatcher@webrtc.org Review-Url: https://codereview.webrtc.org/2834543005 Cr-Commit-Position: refs/heads/master@{#17798} Committed: https://chromium.googlesource.com/external/webrtc/+/d07061c9f3ac5b0514ba02376d5a3ef471d2638b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M webrtc/api/peerconnectioninterface.h View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Taylor Brandstetter
PTAL - just a documentation change.
3 years, 8 months ago (2017-04-20 20:10:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2834543005/1
3 years, 8 months ago (2017-04-20 20:16:11 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 20:19:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d07061c9f3ac5b0514ba02376...

Powered by Google App Engine
This is Rietveld 408576698