Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2833353002: Merge of Echo canceller 3 improvements for setups with headsets. (Closed)

Created:
3 years, 8 months ago by peah-webrtc
Modified:
3 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/branch-heads/59
Project:
webrtc
Visibility:
Public.

Description

Merge of Echo canceller 3 improvements for setups with headsets. This is a merge of the CL https://codereview.webrtc.org/2823903003 into M59. This CL improves the echo cancellation performance on setups where headsets are used (systems with such low echo path gain that no correlation between the render and capture signals can be found) in 4 ways: 1) The echo path gain for systems with headsets is assumed to be nonzero. 2) The stationary component of the render power is not included in nonlinear echo power estimate. 3) The behavior after echo path gain changes is made less cautious. 4) The detection of systems with headsets is made more rapid. NOTRY=true NOPRESUBMIT=true BUG=chromium:712651, webrtc:6018 Review-Url: https://codereview.webrtc.org/2823903003 Cr-Commit-Position: refs/heads/master@{#17768} (cherry picked from commit e52a203a56c7876bc226c04464563555433fa0c1) Review-Url: https://codereview.webrtc.org/2833353002 Cr-Commit-Position: refs/branch-heads/59@{#5} Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657} Committed: https://chromium.googlesource.com/external/webrtc/+/8cb0d9df29d9e344a0d474a44821f40e427852e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -27 lines) Patch
M webrtc/modules/audio_processing/aec3/aec_state.h View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/aec_state.cc View 6 chunks +16 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/residual_echo_estimator.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/residual_echo_estimator.cc View 5 chunks +54 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
peah-webrtc
Hi, This is a merge of an AEC3 CL into M.59. Could you please take ...
3 years, 8 months ago (2017-04-24 07:52:25 UTC) #2
hlundin-webrtc
lgtm
3 years, 8 months ago (2017-04-24 09:42:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2833353002/1
3 years, 8 months ago (2017-04-24 09:47:27 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 8 months ago (2017-04-24 09:47:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2833353002/1
3 years, 8 months ago (2017-04-24 09:48:17 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 09:48:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8cb0d9df29d9e344a0d474a44...

Powered by Google App Engine
This is Rietveld 408576698