Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2832283002:
Remove the expat and jsoncpp to reduce the binary size. (Closed)
DescriptionRemove the expat and jsoncpp dependencies to reduce binary size.
The dependency on third_party/expat/ is removed.
The dependency on third_party/jsoncpp is removed from
libjingle_peerconnection while peerconnection_client still
depends on it.
BUG=webrtc:7516
Review-Url: https://codereview.webrtc.org/2832283002
Cr-Commit-Position: refs/heads/master@{#17848}
Committed: https://chromium.googlesource.com/external/webrtc/+/44d305a80618eb1d3ab481dd3743adbb167382ec
Patch Set 1 #Patch Set 2 #Patch Set 3 : Remove the expat and jsoncpp. #
Messages
Total messages: 28 (19 generated)
The CQ bit was checked by zhihuang@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove the expat to reduce the size. BUG=None. ========== to ========== Remove the expat and jsoncpp to reduce the size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnectin_client still depends on it. BUG=None. ==========
The CQ bit was checked by zhihuang@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Remove the expat and jsoncpp to reduce the size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnectin_client still depends on it. BUG=None. ========== to ========== Remove the expat and jsoncpp to reduce the size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnectin_client still depends on it. BUG=None. ==========
Description was changed from ========== Remove the expat and jsoncpp to reduce the size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnectin_client still depends on it. BUG=None. ========== to ========== Remove the expat and jsoncpp to reduce the size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnectin_client still depends on it. BUG=None ==========
Description was changed from ========== Remove the expat and jsoncpp to reduce the size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnectin_client still depends on it. BUG=None ========== to ========== Remove the expat and jsoncpp to reduce the binary size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnectin_client still depends on it. BUG=None ==========
zhihuang@webrtc.org changed reviewers: + deadbeef@webrtc.org, kjellander@webrtc.org
Please take a look. Thanks.
Description was changed from ========== Remove the expat and jsoncpp to reduce the binary size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnectin_client still depends on it. BUG=None ========== to ========== Remove the expat and jsoncpp to reduce the binary size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnection_client still depends on it. BUG=None ==========
lgtm, thanks for this refactoring! Do you have any binary size estimates you can share? Since this is pretty good stuff, I would also suggest you file a simple bug to reference related to this work. It'll be even more important should this need to be reverted and relanded.
Description was changed from ========== Remove the expat and jsoncpp to reduce the binary size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnection_client still depends on it. BUG=None ========== to ========== Remove the expat and jsoncpp to reduce the binary size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnection_client still depends on it. BUG=webrtc:7516 ==========
On 2017/04/24 06:01:38, kjellander_webrtc wrote: > lgtm, thanks for this refactoring! > Do you have any binary size estimates you can share? I do have some estimates about this which I've shared with you through a doc. > Since this is pretty good > stuff, I would also suggest you file a simple bug to reference related to this > work. It'll be even more important should this need to be reverted and relanded. Done.
Description was changed from ========== Remove the expat and jsoncpp to reduce the binary size. The dependency of the third_party/expat/ is removed. The dependency of third_party/jsoncpp is removed from libjingle_peerconnection while the peerconnection_client still depends on it. BUG=webrtc:7516 ========== to ========== Remove the expat and jsoncpp dependencies to reduce binary size. The dependency on third_party/expat/ is removed. The dependency on third_party/jsoncpp is removed from libjingle_peerconnection while peerconnection_client still depends on it. BUG=webrtc:7516 ==========
lgtm
The CQ bit was checked by zhihuang@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
On 2017/04/24 18:01:51, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...) Retry the libfuzzer bot, the breaking CL is now reverted.
The CQ bit was checked by zhihuang@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493059839407510,
"parent_rev": "9d1ea5cc22f7f8801b6980d524b237088e01f4e1", "commit_rev":
"44d305a80618eb1d3ab481dd3743adbb167382ec"}
Message was sent while issue was closed.
Description was changed from ========== Remove the expat and jsoncpp dependencies to reduce binary size. The dependency on third_party/expat/ is removed. The dependency on third_party/jsoncpp is removed from libjingle_peerconnection while peerconnection_client still depends on it. BUG=webrtc:7516 ========== to ========== Remove the expat and jsoncpp dependencies to reduce binary size. The dependency on third_party/expat/ is removed. The dependency on third_party/jsoncpp is removed from libjingle_peerconnection while peerconnection_client still depends on it. BUG=webrtc:7516 Review-Url: https://codereview.webrtc.org/2832283002 Cr-Commit-Position: refs/heads/master@{#17848} Committed: https://chromium.googlesource.com/external/webrtc/+/44d305a80618eb1d3ab481dd3... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/44d305a80618eb1d3ab481dd3... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
