Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2831603002: Android: Move EglBase10/EglBase14 from to API to src (Closed)

Created:
3 years, 8 months ago by magjed_webrtc
Modified:
3 years, 8 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Move EglBase10/EglBase14 from to API to src BUG=webrtc:7172 Review-Url: https://codereview.webrtc.org/2831603002 Cr-Commit-Position: refs/heads/master@{#17864} Committed: https://chromium.googlesource.com/external/webrtc/+/82de179f7dfed86acf1810fa9e7c95e383e78e8d

Patch Set 1 #

Patch Set 2 : Make classes package private #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -577 lines) Patch
M webrtc/sdk/android/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D webrtc/sdk/android/api/org/webrtc/EglBase10.java View 1 chunk +0 lines, -307 lines 0 comments Download
D webrtc/sdk/android/api/org/webrtc/EglBase14.java View 1 chunk +0 lines, -264 lines 0 comments Download
A + webrtc/sdk/android/src/java/org/webrtc/EglBase10.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/sdk/android/src/java/org/webrtc/EglBase14.java View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
magjed_webrtc
Sami - please take a look. I will make sure the internal bot is passing ...
3 years, 8 months ago (2017-04-19 14:58:15 UTC) #7
sakal
lgtm once the internal bot passes
3 years, 8 months ago (2017-04-21 11:05:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2831603002/40001
3 years, 8 months ago (2017-04-25 12:29:13 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 12:32:12 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/82de179f7dfed86acf1810fa9...

Powered by Google App Engine
This is Rietveld 408576698