GN: Tighten up test target visibility + refactorings

webrtc/video/BUILD.gn

Index: webrtc/video/BUILD.gn
diff --git a/webrtc/video/BUILD.gn b/webrtc/video/BUILD.gn
index 524f84b3688a36e1326839052dc15ae0f7319fdc..967ec5c5559b7837322aadc6d8433d9a421241ac 100644
--- a/webrtc/video/BUILD.gn
+++ b/webrtc/video/BUILD.gn
@@ -79,6 +79,7 @@ rtc_static_library("video") {
 if (rtc_include_tests) {
   rtc_source_set("video_quality_test") {
     testonly = true
+    visibility = [ ":*" ]  # Only targets in this file can depend on this.
     sources = [
       "video_quality_test.cc",
       "video_quality_test.h",
@@ -100,6 +101,9 @@ if (rtc_include_tests) {
 
   rtc_source_set("video_full_stack_tests") {
     testonly = true
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.
+      visibility = [ "//webrtc:webrtc_perf_tests" ]
+    }
     sources = [
       "full_stack_tests.cc",
     ]
@@ -184,6 +188,9 @@ if (rtc_include_tests) {
   # TODO(pbos): Rename test suite.
   rtc_source_set("video_tests") {
     testonly = true
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.
+      visibility = [ "//webrtc:video_engine_tests" ]
+    }
     defines = []
     sources = [
       "call_stats_unittest.cc",