Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/tools/network_tester/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Disable Win compile warning Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/modules/audio_coding/BUILD.gn ('K') | « webrtc/test/fuzzers/BUILD.gn ('k') | webrtc/video/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/tools/network_tester/BUILD.gn
diff --git a/webrtc/tools/network_tester/BUILD.gn b/webrtc/tools/network_tester/BUILD.gn
index 8b1fa85b65cb0fb32110e08176b2bb5b38d48ff4..b1a08017d0fe2bb88bbc34876e88cac3e8db13de 100644
--- a/webrtc/tools/network_tester/BUILD.gn
+++ b/webrtc/tools/network_tester/BUILD.gn
@@ -65,11 +65,14 @@ if (rtc_enable_protobuf) {
}
rtc_source_set("network_tester_unittests") {
+ testonly = true
+ if (!is_android && !is_ios) { # Generated targets makes this check break.
+ visibility = [ "//webrtc/tools:tools_unittests" ]
+ }
sources = [
"network_tester_unittest.cc",
]
- testonly = true
deps = [
":network_tester",
"//testing/gtest",
« webrtc/modules/audio_coding/BUILD.gn ('K') | « webrtc/test/fuzzers/BUILD.gn ('k') | webrtc/video/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698