Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/modules/pacing/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Disable Win compile warning Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/modules/audio_coding/BUILD.gn ('K') | « webrtc/modules/media_file/BUILD.gn ('k') | webrtc/modules/remote_bitrate_estimator/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/pacing/BUILD.gn
diff --git a/webrtc/modules/pacing/BUILD.gn b/webrtc/modules/pacing/BUILD.gn
index d1cf656e6d1ce42c1e02d8b1091616ba4e0491d0..5b126da782013ab2bc74f5eb04b8704a1dddb2d1 100644
--- a/webrtc/modules/pacing/BUILD.gn
+++ b/webrtc/modules/pacing/BUILD.gn
@@ -39,6 +39,9 @@ rtc_static_library("pacing") {
if (rtc_include_tests) {
rtc_source_set("pacing_unittests") {
testonly = true
+ if (!is_android && !is_ios) { # Generated targets makes this check break.
+ visibility = [ "//webrtc/modules:modules_unittests" ]
+ }
sources = [
"alr_detector_unittest.cc",
"bitrate_prober_unittest.cc",
@@ -52,7 +55,7 @@ if (rtc_include_tests) {
"../../system_wrappers:system_wrappers",
"../../test:test_support",
"../rtp_rtcp",
- "../rtp_rtcp:rtp_rtcp_unittests",
+ "../rtp_rtcp:mock_rtp_rtcp",
"//testing/gmock",
]
« webrtc/modules/audio_coding/BUILD.gn ('K') | « webrtc/modules/media_file/BUILD.gn ('k') | webrtc/modules/remote_bitrate_estimator/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698