webrtc/modules/media_file/BUILD.gn - Issue 2828793003: GN: Tighten up test target visibility + refactorings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/media_file/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)

Patch Set: Disable Win compile warning Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/media_file/BUILD.gn

diff --git a/webrtc/modules/media_file/BUILD.gn b/webrtc/modules/media_file/BUILD.gn

index 32825afb2beac863361bc85e388b6913a9573e7d..d2f0a6d9e42f3bf8701eccb66eb882992baef937 100644

--- a/webrtc/modules/media_file/BUILD.gn

+++ b/webrtc/modules/media_file/BUILD.gn

@@ -43,6 +43,9 @@ rtc_static_library("media_file") {

if (rtc_include_tests) {

rtc_source_set("media_file_unittests") {

testonly = true

+ if (!is_android && !is_ios) { # Generated targets makes this check break.

+ visibility = [ "//webrtc/modules:modules_unittests" ]

+ }

sources = [

"media_file_unittest.cc",

]