GN: Tighten up test target visibility + refactorings

webrtc/modules/audio_coding/BUILD.gn

Index: webrtc/modules/audio_coding/BUILD.gn
diff --git a/webrtc/modules/audio_coding/BUILD.gn b/webrtc/modules/audio_coding/BUILD.gn
index 9c7e5eec5541adcaf514f73309e1857c78638cbc..6a34ab7eeec9dee27feaf5d635948101646690ad 100644
--- a/webrtc/modules/audio_coding/BUILD.gn
+++ b/webrtc/modules/audio_coding/BUILD.gn
@@ -1168,6 +1168,11 @@ if (rtc_include_tests) {
 
   rtc_source_set("audio_coding_modules_tests") {
     testonly = true
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.
+      if (!is_android && !is_ios) {  # Generated targets makes this check break.
+        visibility = [ "//webrtc/modules:modules_tests" ]
+      }
+    }
     sources = [
       "test/APITest.cc",
       "test/Channel.cc",
@@ -1212,6 +1217,9 @@ if (rtc_include_tests) {
 
   rtc_source_set("audio_coding_perf_tests") {
     testonly = true
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.
+      visibility = [ "//webrtc:webrtc_perf_tests" ]
+    }
     sources = [
       "codecs/opus/opus_complexity_unittest.cc",
       "neteq/test/neteq_performance_unittest.cc",
@@ -2014,7 +2022,11 @@ if (rtc_include_tests) {
 
   rtc_source_set("audio_coding_unittests") {
     testonly = true
-
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.

[stefan-webrtc, 2017/04/21 12:28:28]

Why twice? :)

[kjellander_webrtc, 2017/04/21 12:48:21]

Search-replace error. Fixed :)

+      if (!is_android && !is_ios) {  # Generated targets makes this check break.
+        visibility = [ "//webrtc/modules:modules_unittests" ]
+      }
+    }
     sources = [
       "acm2/acm_receiver_unittest.cc",
       "acm2/audio_coding_module_unittest.cc",