Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/call/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Disable Win compile warning Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/api/BUILD.gn ('K') | « webrtc/base/BUILD.gn ('k') | webrtc/modules/audio_coding/BUILD.gn » ('j') | webrtc/modules/audio_coding/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/BUILD.gn
diff --git a/webrtc/call/BUILD.gn b/webrtc/call/BUILD.gn
index f1345cf5ac6d5537695b15bfc3d069f3b74b3c3b..0a70e1982b7a5b9d3997b627606927fd9bd548de 100644
--- a/webrtc/call/BUILD.gn
+++ b/webrtc/call/BUILD.gn
@@ -71,6 +71,9 @@ rtc_static_library("call") {
if (rtc_include_tests) {
rtc_source_set("call_tests") {
testonly = true
+ if (!is_android && !is_ios) { # Generated targets makes this check break.
+ visibility = [ "//webrtc:video_engine_tests" ]
+ }
sources = [
"bitrate_allocator_unittest.cc",
"bitrate_estimator_tests.cc",
@@ -103,6 +106,9 @@ if (rtc_include_tests) {
rtc_source_set("call_perf_tests") {
testonly = true
+ if (!is_android && !is_ios) { # Generated targets makes this check break.
+ visibility = [ "//webrtc:webrtc_perf_tests" ]
+ }
sources = [
"call_perf_tests.cc",
"rampup_tests.cc",
« webrtc/api/BUILD.gn ('K') | « webrtc/base/BUILD.gn ('k') | webrtc/modules/audio_coding/BUILD.gn » ('j') | webrtc/modules/audio_coding/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698