GN: Tighten up test target visibility + refactorings

webrtc/base/BUILD.gn

Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index 6280903b58fa370bfc81501eeeea24fe734c0971..be549791d9058f252962c9552a004630d1d8e627 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -736,6 +736,9 @@ if (rtc_include_tests) {
 
   rtc_source_set("rtc_base_nonparallel_tests") {
     testonly = true
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.
+      visibility = [ "//webrtc:webrtc_nonparallel_tests" ]
+    }
     sources = [
       "cpu_time_unittest.cc",
       "filerotatingstream_unittest.cc",
@@ -763,6 +766,9 @@ if (rtc_include_tests) {
 
   rtc_source_set("rtc_base_approved_unittests") {
     testonly = true
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.
+      visibility = [ "//webrtc:rtc_unittests" ]
+    }
     sources = [
       "array_view_unittest.cc",
       "atomicops_unittest.cc",
@@ -814,6 +820,9 @@ if (rtc_include_tests) {
 
   rtc_source_set("rtc_task_queue_unittests") {
     testonly = true
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.
+      visibility = [ "//webrtc:rtc_unittests" ]
+    }
     sources = [
       "sequenced_task_checker_unittest.cc",
       "task_queue_unittest.cc",
@@ -831,6 +840,9 @@ if (rtc_include_tests) {
 
   rtc_source_set("rtc_numerics_unittests") {
     testonly = true
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.
+      visibility = [ "//webrtc:rtc_unittests" ]
+    }
     sources = [
       "numerics/exp_filter_unittest.cc",
       "numerics/percentile_filter_unittest.cc",
@@ -848,6 +860,9 @@ if (rtc_include_tests) {
   }
   rtc_source_set("rtc_base_unittests") {
     testonly = true
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.
+      visibility = [ "//webrtc:rtc_unittests" ]
+    }
     sources = [
       "callback_unittest.cc",
       "crc32_unittest.cc",