GN: Tighten up test target visibility + refactorings

webrtc/modules/audio_coding/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../webrtc.gni")
 import("audio_coding.gni")
@@ skipping 1150 matching lines @@
       ":rtpcat",
       ":webrtc_opus_fec_test",
     ]
     if (rtc_enable_protobuf) {
       public_deps += [ ":neteq_rtpplay" ]
     }
   }
 
   rtc_source_set("audio_coding_modules_tests") {
     testonly = true
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.
+      if (!is_android && !is_ios) {  # Generated targets makes this check break.
+        visibility = [ "//webrtc/modules:modules_tests" ]
+      }
+    }
     sources = [
       "test/APITest.cc",
       "test/Channel.cc",
       "test/EncodeDecodeTest.cc",
       "test/PCMFile.cc",
       "test/PacketLossTest.cc",
       "test/RTPFile.cc",
       "test/TestAllCodecs.cc",
       "test/TestRedFec.cc",
       "test/TestStereo.cc",
@@ skipping 24 matching lines @@
       ]
     }
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
   rtc_source_set("audio_coding_perf_tests") {
     testonly = true
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.
+      visibility = [ "//webrtc:webrtc_perf_tests" ]
+    }
     sources = [
       "codecs/opus/opus_complexity_unittest.cc",
       "neteq/test/neteq_performance_unittest.cc",
     ]
     deps = [
       ":neteq_test_support",
       ":neteq_unittest_tools",
       ":webrtc_opus",
       "../..:webrtc_common",
       "../../base:protobuf_utils",
@@ skipping 782 matching lines @@
     ]
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
   rtc_source_set("audio_coding_unittests") {
     testonly = true
-
+    if (!is_android && !is_ios) {  # Generated targets makes this check break.

[stefan-webrtc, 2017/04/21 12:28:28]

Why twice? :)

[kjellander_webrtc, 2017/04/21 12:48:21]

Search-replace error. Fixed :)

+      if (!is_android && !is_ios) {  # Generated targets makes this check break.
+        visibility = [ "//webrtc/modules:modules_unittests" ]
+      }
+    }
     sources = [
       "acm2/acm_receiver_unittest.cc",
       "acm2/audio_coding_module_unittest.cc",
       "acm2/call_statistics_unittest.cc",
       "acm2/codec_manager_unittest.cc",
       "acm2/rent_a_codec_unittest.cc",
       "audio_network_adaptor/audio_network_adaptor_impl_unittest.cc",
       "audio_network_adaptor/bitrate_controller_unittest.cc",
       "audio_network_adaptor/channel_controller_unittest.cc",
       "audio_network_adaptor/controller_manager_unittest.cc",
@@ skipping 143 matching lines @@
 # webrtc/api/audio_codecs:builtin_audio_decoder_factory instead.
 # TODO(kwiberg): Remove this.
 rtc_source_set("builtin_audio_decoder_factory") {
   sources = [
     "codecs/builtin_audio_decoder_factory.h",
   ]
   deps = [
     "../../api/audio_codecs:builtin_audio_decoder_factory",
   ]
 }