Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: webrtc/modules/audio_conference_mixer/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Disable Win compile warning Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../webrtc.gni") 9 import("../../webrtc.gni")
10 10
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 "../../audio/utility:audio_frame_operations", 43 "../../audio/utility:audio_frame_operations",
44 "../../base:rtc_base_approved", 44 "../../base:rtc_base_approved",
45 "../../system_wrappers", 45 "../../system_wrappers",
46 "../audio_processing", 46 "../audio_processing",
47 ] 47 ]
48 } 48 }
49 49
50 if (rtc_include_tests) { 50 if (rtc_include_tests) {
51 rtc_source_set("audio_conference_mixer_unittests") { 51 rtc_source_set("audio_conference_mixer_unittests") {
52 testonly = true 52 testonly = true
53 if (!is_android && !is_ios) { # Generated targets makes this check break.
54 visibility = [ "//webrtc/modules:modules_unittests" ]
55 }
53 sources = [ 56 sources = [
54 "test/audio_conference_mixer_unittest.cc", 57 "test/audio_conference_mixer_unittest.cc",
55 ] 58 ]
56 deps = [ 59 deps = [
57 ":audio_conference_mixer", 60 ":audio_conference_mixer",
58 "../../test:test_support", 61 "../../test:test_support",
59 "//testing/gmock", 62 "//testing/gmock",
60 ] 63 ]
61 if (is_win) { 64 if (is_win) {
62 cflags = [ 65 cflags = [
63 # TODO(kjellander): bugs.webrtc.org/261: Fix this warning. 66 # TODO(kjellander): bugs.webrtc.org/261: Fix this warning.
64 "/wd4373", # virtual function override. 67 "/wd4373", # virtual function override.
65 ] 68 ]
66 } 69 }
67 if (!build_with_chromium && is_clang) { 70 if (!build_with_chromium && is_clang) {
68 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 71 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
69 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 72 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
70 } 73 }
71 } 74 }
72 } 75 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698