Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2827643003: Adding integration test for unsignaled inbound RTP stream stats. (Closed)

Created:
3 years, 8 months ago by Taylor Brandstetter
Modified:
3 years, 8 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding integration test for unsignaled inbound RTP stream stats. The test isn't complete, since "track_id" ends up unset. But it's better than having no test at all. BUG=None Review-Url: https://codereview.webrtc.org/2827643003 Cr-Commit-Position: refs/heads/master@{#17753} Committed: https://chromium.googlesource.com/external/webrtc/+/d8ad788a2b4b413a53d0bb6c9e6a68594a3e7e16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -29 lines) Patch
M webrtc/pc/peerconnection_integrationtest.cc View 13 chunks +74 lines, -29 lines 0 comments Download
M webrtc/pc/test/mockpeerconnectionobservers.h View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Taylor Brandstetter
PTAL
3 years, 8 months ago (2017-04-18 17:42:55 UTC) #2
pthatcher1
lgtm
3 years, 8 months ago (2017-04-18 20:17:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2827643003/1
3 years, 8 months ago (2017-04-18 22:43:06 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 23:01:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d8ad788a2b4b413a53d0bb6c9...

Powered by Google App Engine
This is Rietveld 408576698