Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2826063002: Android: Prepare moving EglBase10/EglBase14 from to API to src (Closed)

Created:
3 years, 8 months ago by magjed_webrtc
Modified:
3 years, 8 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Prepare moving EglBase10/EglBase14 from to API to src BUG=webrtc:7172 Review-Url: https://codereview.webrtc.org/2826063002 Cr-Commit-Position: refs/heads/master@{#17807} Committed: https://chromium.googlesource.com/external/webrtc/+/b04646f38bef1715fc1d8788f7343125ad3f2990

Patch Set 1 #

Patch Set 2 : Rename createEgl to createEgl10 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M webrtc/sdk/android/api/org/webrtc/EglBase.java View 1 2 chunks +28 lines, -3 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/EglRenderer.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
magjed_webrtc
Sami - please take a look.
3 years, 8 months ago (2017-04-19 14:51:02 UTC) #7
sakal
lgtm
3 years, 8 months ago (2017-04-20 15:50:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2826063002/20001
3 years, 8 months ago (2017-04-21 08:12:04 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 08:34:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/b04646f38bef1715fc1d8788f...

Powered by Google App Engine
This is Rietveld 408576698