Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2825333002: Replace first_packet_sent_ms_ in Call. (Closed)

Created:
3 years, 8 months ago by åsapersson
Modified:
3 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace first_packet_sent_ms_ in Call. Instead of using the time on the first callback to Call::OnSentPacket, use the time when the first packet is sent from the pacer (to make sure this packet corresponds to an audio/video RTP packet). BUG=webrtc:6244 Review-Url: https://codereview.webrtc.org/2825333002 Cr-Commit-Position: refs/heads/master@{#17777} Committed: https://chromium.googlesource.com/external/webrtc/+/fc5e81c979183df3ae5e451838a19e2228205c0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -9 lines) Patch
M webrtc/call/call.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M webrtc/modules/congestion_controller/include/send_side_congestion_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
åsapersson
3 years, 8 months ago (2017-04-19 13:53:21 UTC) #5
stefan-webrtc
Thanks for this! lgtm
3 years, 8 months ago (2017-04-19 14:08:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2825333002/1
3 years, 8 months ago (2017-04-20 06:26:21 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 06:28:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fc5e81c979183df3ae5e45183...

Powered by Google App Engine
This is Rietveld 408576698