Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: webrtc/tools/event_log_visualizer/plot_base.cc

Issue 2824973003: Event log visualizer TimeSeries is now created on the stack and then moved into the vector of serie… (Closed)
Patch Set: Feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/tools/event_log_visualizer/plot_base.h ('k') | webrtc/tools/event_log_visualizer/plot_python.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/tools/event_log_visualizer/plot_base.cc
diff --git a/webrtc/tools/event_log_visualizer/plot_base.cc b/webrtc/tools/event_log_visualizer/plot_base.cc
index baee3dfeee3cd0708bd8e490a791b0560802fa33..057a3108a4c7fc9f090837d29765b0bef58ecf2b 100644
--- a/webrtc/tools/event_log_visualizer/plot_base.cc
+++ b/webrtc/tools/event_log_visualizer/plot_base.cc
@@ -71,14 +71,8 @@ void Plot::SetTitle(std::string title) {
title_ = title;
}
-TimeSeries* Plot::AddTimeSeries(const char* label, PlotStyle style) {
- series_list_.emplace_back(label, style);
- return &series_list_.back();
-}
-
-TimeSeries* Plot::AddTimeSeries(const std::string& label, PlotStyle style) {
- series_list_.emplace_back(label, style);
- return &series_list_.back();
+void Plot::AppendTimeSeries(TimeSeries&& time_series) {
+ series_list_.emplace_back(std::move(time_series));
}
} // namespace plotting
« no previous file with comments | « webrtc/tools/event_log_visualizer/plot_base.h ('k') | webrtc/tools/event_log_visualizer/plot_python.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698