Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: webrtc/tools/event_log_visualizer/plot_base.cc

Issue 2824973003: Event log visualizer TimeSeries is now created on the stack and then moved into the vector of serie… (Closed)
Patch Set: Feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 max_value = std::max(max_value, point.y); 64 max_value = std::max(max_value, point.y);
65 } 65 }
66 } 66 }
67 SetYAxis(min_value, max_value, label, bottom_margin, top_margin); 67 SetYAxis(min_value, max_value, label, bottom_margin, top_margin);
68 } 68 }
69 69
70 void Plot::SetTitle(std::string title) { 70 void Plot::SetTitle(std::string title) {
71 title_ = title; 71 title_ = title;
72 } 72 }
73 73
74 TimeSeries* Plot::AddTimeSeries(const char* label, PlotStyle style) { 74 void Plot::AppendTimeSeries(TimeSeries&& time_series) {
75 series_list_.emplace_back(label, style); 75 series_list_.emplace_back(std::move(time_series));
76 return &series_list_.back();
77 }
78
79 TimeSeries* Plot::AddTimeSeries(const std::string& label, PlotStyle style) {
80 series_list_.emplace_back(label, style);
81 return &series_list_.back();
82 } 76 }
83 77
84 } // namespace plotting 78 } // namespace plotting
85 } // namespace webrtc 79 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/tools/event_log_visualizer/plot_base.h ('k') | webrtc/tools/event_log_visualizer/plot_python.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698