Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h

Issue 2822153002: Remove rtcp::TransportFeedback::GetStatusVector/GetReceiveDeltas (Closed)
Patch Set: bit more simplifications Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/congestion_controller/transport_feedback_adapter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h
index fa6ef046210b748157d38dcd4e307768384fca35..808a4a6f4cfe8496124ce414be44f0c0ac87dbf4 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h
@@ -14,6 +14,7 @@
#include <memory>
#include <vector>
+#include "webrtc/base/deprecation.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/rtpfb.h"
namespace webrtc {
@@ -61,14 +62,17 @@ class TransportFeedback : public Rtpfb {
};
uint16_t GetBaseSequence() const;
- std::vector<TransportFeedback::StatusSymbol> GetStatusVector() const;
- std::vector<int16_t> GetReceiveDeltas() const;
+ // Returns number of packets (including missing) this feedback describes.
+ size_t GetPacketStatusCount() const { return num_seq_no_; }
+ RTC_DEPRECATED std::vector<TransportFeedback::StatusSymbol> GetStatusVector()
philipel 2017/04/19 12:34:59 Why don't we remove GetStatusVector, GetReceiveDel
danilchap 2017/04/19 14:05:35 No good reason. Done
+ const;
+ RTC_DEPRECATED std::vector<int16_t> GetReceiveDeltas() const;
// Get the reference time in microseconds, including any precision loss.
int64_t GetBaseTimeUs() const;
// Convenience method for getting all deltas as microseconds. The first delta
// is relative the base time.
- std::vector<int64_t> GetReceiveDeltasUs() const;
+ RTC_DEPRECATED std::vector<int64_t> GetReceiveDeltasUs() const;
bool Parse(const CommonHeader& packet);
static std::unique_ptr<TransportFeedback> ParseFrom(const uint8_t* buffer,
« no previous file with comments | « webrtc/modules/congestion_controller/transport_feedback_adapter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698