Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2821373003: Android: Move CameraStatistics from API to src (Closed)

Created:
3 years, 8 months ago by magjed_webrtc
Modified:
3 years, 8 months ago
Reviewers:
sakal-chromium, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Move CameraStatistics from API to src BUG=webrtc:7172 Review-Url: https://codereview.webrtc.org/2821373003 Cr-Commit-Position: refs/heads/master@{#17765} Committed: https://chromium.googlesource.com/external/webrtc/+/800daef50a7ae1204a5e2ec77569366d9e7b641a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -69 lines) Patch
M webrtc/sdk/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/CameraVideoCapturer.java View 1 chunk +0 lines, -69 lines 0 comments Download
A webrtc/sdk/android/src/java/org/webrtc/CameraStatistics.java View 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
magjed_webrtc
Sami - please take a look.
3 years, 8 months ago (2017-04-19 13:20:28 UTC) #5
sakal-chromium
lgtm
3 years, 8 months ago (2017-04-19 13:23:09 UTC) #7
sakal
lgtm
3 years, 8 months ago (2017-04-19 13:23:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2821373003/1
3 years, 8 months ago (2017-04-19 14:49:03 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/800daef50a7ae1204a5e2ec77569366d9e7b641a
3 years, 8 months ago (2017-04-19 14:51:43 UTC) #16
magjed_webrtc
3 years, 8 months ago (2017-04-19 15:45:32 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2825383002/ by magjed@webrtc.org.

The reason for reverting is: Breaks external clients..

Powered by Google App Engine
This is Rietveld 408576698