Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2818563003: Rename the webrtc_adm_linux* namespaces to webrtc::adm_linux* (Closed)

Created:
3 years, 8 months ago by kwiberg-webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename the webrtc_adm_linux* namespaces to webrtc::adm_linux* We shouldn't pollute the global namespace. BUG=webrtc:7484 Review-Url: https://codereview.webrtc.org/2818563003 Cr-Commit-Position: refs/heads/master@{#17734} Committed: https://chromium.googlesource.com/external/webrtc/+/6daffe206d7a9f911c632a17cb697468ef0f31b1

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
kwiberg-webrtc
3 years, 8 months ago (2017-04-13 11:51:30 UTC) #6
Henrik Grunell WebRTC
lgtm
3 years, 8 months ago (2017-04-18 07:47:57 UTC) #7
henrika_webrtc
lgtm
3 years, 8 months ago (2017-04-18 08:04:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2818563003/1
3 years, 8 months ago (2017-04-18 08:08:08 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 08:26:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/6daffe206d7a9f911c632a17c...

Powered by Google App Engine
This is Rietveld 408576698