Chromium Code Reviews

Issue 2815573004: Revert of Reland "Add first part of the network_tester functionality" (Closed)

Created:
3 years, 8 months ago by michaelt
Modified:
3 years, 8 months ago
Reviewers:
terelius, minyue-webrtc, stefan-webrtc, nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Reland "Add first part of the network_tester functionality" (patchset #3 id:40001 of https://codereview.webrtc.org/2808203003/ ) Reason for revert: Hit infra. bug. which need to be fixed first. Original issue's description: > Reland "Add first part of the network_tester functionality" > > BUG=webrtc:7426 > > Review-Url: https://codereview.webrtc.org/2808203003 > Cr-Commit-Position: refs/heads/master@{#17666} > Committed: https://chromium.googlesource.com/external/webrtc/+/1c223b2f7557ff449add7a114d72ea97614731b5 TBR=stefan@webrtc.org,minyue@webrtc.org,nisse@webrtc.org,terelius@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7426

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -680 lines)
D resources/network_tester/client_config.dat.sha1 View 1 chunk +0 lines, -1 line 0 comments
D resources/network_tester/server_config.dat.sha1 View 1 chunk +0 lines, -1 line 0 comments
M webrtc/tools/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments
M webrtc/tools/DEPS View 1 chunk +0 lines, -1 line 0 comments
D webrtc/tools/network_tester/BUILD.gn View 1 chunk +0 lines, -93 lines 0 comments
D webrtc/tools/network_tester/config_reader.h View 1 chunk +0 lines, -53 lines 0 comments
D webrtc/tools/network_tester/config_reader.cc View 1 chunk +0 lines, -50 lines 0 comments
D webrtc/tools/network_tester/create_network_tester_config.py View 1 chunk +0 lines, -30 lines 0 comments
D webrtc/tools/network_tester/network_tester_config.proto View 1 chunk +0 lines, -13 lines 0 comments
D webrtc/tools/network_tester/network_tester_packet.proto View 1 chunk +0 lines, -18 lines 0 comments
D webrtc/tools/network_tester/network_tester_unittest.cc View 1 chunk +0 lines, -29 lines 0 comments
D webrtc/tools/network_tester/packet_sender.h View 1 chunk +0 lines, -64 lines 0 comments
D webrtc/tools/network_tester/packet_sender.cc View 1 chunk +0 lines, -129 lines 0 comments
D webrtc/tools/network_tester/test_controller.h View 1 chunk +0 lines, -75 lines 0 comments
D webrtc/tools/network_tester/test_controller.cc View 1 chunk +0 lines, -118 lines 0 comments

Messages

Total messages: 6 (2 generated)
michaelt
Created Revert of Reland "Add first part of the network_tester functionality"
3 years, 8 months ago (2017-04-12 15:18:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2815573004/1
3 years, 8 months ago (2017-04-12 15:18:19 UTC) #3
commit-bot: I haz the power
Failed to apply patch for resources/network_tester/client_config.dat.sha1: While running git rm resources/network_tester/client_config.dat.sha1; fatal: pathspec 'resources/network_tester/client_config.dat.sha1' did ...
3 years, 8 months ago (2017-04-12 15:18:27 UTC) #5
minyue-webrtc
3 years, 8 months ago (2017-04-12 15:20:50 UTC) #6
On 2017/04/12 15:18:27, commit-bot: I haz the power wrote:
> Failed to apply patch for resources/network_tester/client_config.dat.sha1:
> While running git rm resources/network_tester/client_config.dat.sha1;
>   fatal: pathspec 'resources/network_tester/client_config.dat.sha1' did not
> match any files
> 
> Patch:  D    resources/network_tester/client_config.dat.sha1
> Index: resources/network_tester/client_config.dat.sha1
> diff --git a/resources/network_tester/client_config.dat.sha1
> b/resources/network_tester/client_config.dat.sha1
> deleted file mode 100644
> index
>
925be43053b81401918e2d0afbef4cb800f73079..0000000000000000000000000000000000000000
> --- a/resources/network_tester/client_config.dat.sha1
> +++ /dev/null
> @@ -1 +0,0 @@
> -8a7265ba397c621574b321a451605ac94f58b1d3
> \ No newline at end of file

Please delete this CL. A revert was already made.

Powered by Google App Engine