Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2815203002:
Don't add stuff to namespace std (Closed)
|
Created:
3 years, 8 months ago by kwiberg-webrtc Modified:
3 years, 8 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDon't add stuff to namespace std
The compiler is allowed to leave a chopped-off horse's head on your
bed if you do.
Happily, we didn't even have to move this function to another namespace,
since it was unused.
BUG=webrtc:7484
Review-Url: https://codereview.webrtc.org/2815203002
Cr-Commit-Position: refs/heads/master@{#17696}
Committed: https://chromium.googlesource.com/external/webrtc/+/749cc8a49371fefc701bb049faf6bdb821203dcb
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove it instead #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kwiberg@webrtc.org changed reviewers: + magjed@webrtc.org
https://codereview.webrtc.org/2815203002/diff/1/webrtc/media/base/videoengine... File webrtc/media/base/videoengine_unittest.h (right): https://codereview.webrtc.org/2815203002/diff/1/webrtc/media/base/videoengine... webrtc/media/base/videoengine_unittest.h:63: inline std::ostream& operator<<(std::ostream& s, const VideoCodec& c) { This function is not used so just remove it instead. There is a toString() function in cricket::VideoCodec already
The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Don't add stuff to namespace std The compiler is allowed to leave a chopped-off horse's head on your bed if you do. BUG=webrtc:7484 ========== to ========== Don't add stuff to namespace std The compiler is allowed to leave a chopped-off horse's head on your bed if you do. Happily, we didn't even have to move this function to another namespace, since it was unused. BUG=webrtc:7484 ==========
https://codereview.webrtc.org/2815203002/diff/1/webrtc/media/base/videoengine... File webrtc/media/base/videoengine_unittest.h (right): https://codereview.webrtc.org/2815203002/diff/1/webrtc/media/base/videoengine... webrtc/media/base/videoengine_unittest.h:63: inline std::ostream& operator<<(std::ostream& s, const VideoCodec& c) { On 2017/04/13 09:56:02, magjed_webrtc wrote: > This function is not used so just remove it instead. There is a toString() > function in cricket::VideoCodec already Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by kwiberg@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492091276931020,
"parent_rev": "8b9a24e4d6212f7c7351fd66d8e4b53042d0c2bf", "commit_rev":
"749cc8a49371fefc701bb049faf6bdb821203dcb"}
Message was sent while issue was closed.
Description was changed from ========== Don't add stuff to namespace std The compiler is allowed to leave a chopped-off horse's head on your bed if you do. Happily, we didn't even have to move this function to another namespace, since it was unused. BUG=webrtc:7484 ========== to ========== Don't add stuff to namespace std The compiler is allowed to leave a chopped-off horse's head on your bed if you do. Happily, we didn't even have to move this function to another namespace, since it was unused. BUG=webrtc:7484 Review-Url: https://codereview.webrtc.org/2815203002 Cr-Commit-Position: refs/heads/master@{#17696} Committed: https://chromium.googlesource.com/external/webrtc/+/749cc8a49371fefc701bb049f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/749cc8a49371fefc701bb049f... |
