Add command-line param to screenshare_loopback to specify a list of slides

Add command-line param to screenshare_loopback to specify a list of slides

BUG=none

Review-Url: https://codereview.webrtc.org/2814023003
Cr-Commit-Position: refs/heads/master@{#17670}
Committed: https://chromium.googlesource.com/external/webrtc/+/8d8185c7743f2713908a1823656493c13fc8ea67

[ilnik, 2017-04-12 09:02:47]

Description was changed from

==========
Add command-line param to screenshare_loopback to specify a list of slides

BUG=none
==========

to

==========
Add command-line param to screenshare_loopback to specify a list of slides

BUG=none
==========

[ilnik, 2017-04-12 09:02:47]

ilnik@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[ilnik, 2017-04-12 09:04:38]

ilnik@webrtc.org changed reviewers:
+ tommi@webrtc.org
- asapersson@webrtc.org

[ilnik, 2017-04-12 09:52:09]

ilnik@webrtc.org changed reviewers:
+ tommi@chromium.org
- tommi@webrtc.org

[tommi, 2017-04-12 11:02:03]

tommi@webrtc.org changed reviewers:
+ tommi@webrtc.org

[tommi, 2017-04-12 11:02:03]

lgtm

[ilnik, 2017-04-12 11:06:04]

On 2017/04/12 11:02:03, tommi (wëbrtc) wrote:
> lgtm

I actually found existing function. Now it's shorter. Still lgtm?

[tommi, 2017-04-12 11:30:39]

yes even lgtm-er!

https://codereview.webrtc.org/2814023003/diff/20001/webrtc/video/screenshare_...
File webrtc/video/screenshare_loopback.cc (right):

https://codereview.webrtc.org/2814023003/diff/20001/webrtc/video/screenshare_...
webrtc/video/screenshare_loopback.cc:224: rtc::tokenize(slides_list, ',',
&slides);
nice!

[ilnik, 2017-04-12 11:31:39]

The CQ bit was checked by ilnik@webrtc.org

[commit-bot: I haz the power, 2017-04-12 11:31:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-12 11:52:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491996699121180,
"parent_rev": "e52b8ace0af15e59c94c905e3519c945a9aa1ede", "commit_rev":
"8d8185c7743f2713908a1823656493c13fc8ea67"}

[commit-bot: I haz the power, 2017-04-12 11:52:59]

Description was changed from

==========
Add command-line param to screenshare_loopback to specify a list of slides

BUG=none
==========

to

==========
Add command-line param to screenshare_loopback to specify a list of slides

BUG=none

Review-Url: https://codereview.webrtc.org/2814023003
Cr-Commit-Position: refs/heads/master@{#17670}
Committed:
https://chromium.googlesource.com/external/webrtc/+/8d8185c7743f2713908a18236...
==========

[commit-bot: I haz the power, 2017-04-12 11:52:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8d8185c7743f2713908a18236...