Ensure SetREMBStatus(false) disables sending REMB

Ensure SetREMBStatus(false) disables sending REMB

support CL for upcoming https://codereview.webrtc.org/2789843002/

BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/2813693003
Cr-Commit-Position: refs/heads/master@{#17741}
Committed: https://chromium.googlesource.com/external/webrtc/+/ba6aa90c0417ebe30bd674f34c5180c74932f3df

[danilchap, 2017-04-11 15:42:51]

Patchset #1 (id:1) has been deleted

[danilchap, 2017-04-11 15:43:01]

Patchset #1 (id:20001) has been deleted

[danilchap, 2017-04-11 15:44:40]

danilchap@webrtc.org changed reviewers:
+ nisse@webrtc.org

[danilchap, 2017-04-11 17:49:52]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 17:49:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-11 18:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 18:15:58]

Dry run: This issue passed the CQ dry run.

[nisse-webrtc, 2017-04-18 12:25:43]

A find the SetFlag and ConsumeFlag methods a bit confusing, but if I get it
right, the kRtcpRemb flag is set by SetREMBData, if |remb_enabled_| is true, and
it is cleared by SetREMBStatus, if |remb_enabled_| is set to false. Correct?

lgtm

[danilchap, 2017-04-18 12:37:41]

On 2017/04/18 12:25:43, nisse-webrtc wrote:
> A find the SetFlag and ConsumeFlag methods a bit confusing, but if I get it
> right, the kRtcpRemb flag is set by SetREMBData, if |remb_enabled_| is true,
and
> it is cleared by SetREMBStatus, if |remb_enabled_| is set to false. Correct?
yes, that is correct

SetFlag/ConsumeFlag are confusing:
2nd parameter of a SetFlag ask if flag is volatile [i.e. removed once respective
rtcp message is send] or persistent [kept and resend with each report].
value false make it persistent.
for ConsumeFlag meaning sort of reverse: flag is called force. Value true mean
clear it even if it is set as persistent, while value false clear only volatile
flags.
so to counter SetFlag(,false) one must call ConsumeFlag(,true)
while SetFlag(,true) usually cleaned with ConsumeFlag(,false)

[danilchap, 2017-04-18 12:37:47]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2017-04-18 12:37:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-18 13:57:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492519067354370,
"parent_rev": "1b96531f9eb82d3f9ccf8ec2cda20a86cfaad656", "commit_rev":
"ba6aa90c0417ebe30bd674f34c5180c74932f3df"}

[commit-bot: I haz the power, 2017-04-18 13:57:06]

Description was changed from

==========
Ensure SetREMBStatus(false) disables sending REMB

support CL for upcoming https://codereview.webrtc.org/2789843002/

BUG=webrtc:7135
==========

to

==========
Ensure SetREMBStatus(false) disables sending REMB

support CL for upcoming https://codereview.webrtc.org/2789843002/

BUG=webrtc:7135

Review-Url: https://codereview.webrtc.org/2813693003
Cr-Commit-Position: refs/heads/master@{#17741}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ba6aa90c0417ebe30bd674f34...
==========

[commit-bot: I haz the power, 2017-04-18 13:57:07]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/ba6aa90c0417ebe30bd674f34...