Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2813493004: Added audioSessionDidActivate and audioSessionDidDectivate (Closed)

Created:
3 years, 8 months ago by jtt_webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added audioSessionDidActivate and audioSessionDidDectivate so that RTCAudioSession can be notified when the audio session is activated or deactivated by iOS outside of the app. BUG=webrtc:7446 Review-Url: https://codereview.webrtc.org/2813493004 Cr-Commit-Position: refs/heads/master@{#17743} Committed: https://chromium.googlesource.com/external/webrtc/+/3c9a6c0aff7b7d154b04390961072966252139d0

Patch Set 1 #

Patch Set 2 : removed @required #

Patch Set 3 : cleanup #

Patch Set 4 : cleanup #

Patch Set 5 : cleanup #

Patch Set 6 : Merge branch 'master' of https://chromium.googlesource.com/external/webrtc into activeCount #

Total comments: 1

Patch Set 7 : move test to ios only #

Patch Set 8 : moved audio test into existing RTCAudioSessionTest.mm #

Patch Set 9 : remove code not for this cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M webrtc/modules/audio_device/ios/objc/RTCAudioSession.h View 1 2 3 chunks +16 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm View 1 2 3 4 5 6 7 8 1 chunk +16 lines, -0 lines 0 comments Download
M webrtc/modules/audio_device/ios/objc/RTCAudioSessionTest.mm View 1 2 3 4 5 6 7 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (16 generated)
jtt_webrtc
Somehow the CL changed. Here is the up to date one.
3 years, 8 months ago (2017-04-13 20:08:18 UTC) #1
jtt_webrtc
resending
3 years, 8 months ago (2017-04-13 20:09:33 UTC) #3
tkchin_webrtc
lgtm https://codereview.webrtc.org/2813493004/diff/100001/webrtc/sdk/objc/Framework/UnitTests/RTCAudioSessionTest.mm File webrtc/sdk/objc/Framework/UnitTests/RTCAudioSessionTest.mm (right): https://codereview.webrtc.org/2813493004/diff/100001/webrtc/sdk/objc/Framework/UnitTests/RTCAudioSessionTest.mm#newcode27 webrtc/sdk/objc/Framework/UnitTests/RTCAudioSessionTest.mm:27: it'd be nice to have a unit test ...
3 years, 8 months ago (2017-04-13 20:17:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2813493004/100001
3 years, 8 months ago (2017-04-13 20:28:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/20748)
3 years, 8 months ago (2017-04-13 20:31:39 UTC) #9
jtt_webrtc
Had to move the audio session test to iOS only in BUILD.gn
3 years, 8 months ago (2017-04-13 21:00:06 UTC) #14
jtt_webrtc
Moved tests to RTCAudioSessionTest.mm.
3 years, 8 months ago (2017-04-13 21:36:25 UTC) #17
jtt_webrtc
Bump. Need this to be checked in before I can cl the fix for configureWebRTCSession
3 years, 8 months ago (2017-04-17 18:07:31 UTC) #20
henrika_webrtc
lgtm. Thanks for improvements.
3 years, 8 months ago (2017-04-18 08:19:04 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2813493004/160001
3 years, 8 months ago (2017-04-18 15:46:26 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 16:09:42 UTC) #27
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/external/webrtc/+/3c9a6c0aff7b7d154b0439096...

Powered by Google App Engine
This is Rietveld 408576698