Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2813373002: Don't make a top-level namespace called "voetest" (Closed)

Created:
3 years, 8 months ago by kwiberg-webrtc
Modified:
3 years, 8 months ago
Reviewers:
the sun, ossu
CC:
webrtc-reviews_webrtc.org, AleBzk, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't make a top-level namespace called "voetest" We shouldn't pollute the global namespace. BUG=webrtc:7484 Review-Url: https://codereview.webrtc.org/2813373002 Cr-Commit-Position: refs/heads/master@{#17797} Committed: https://chromium.googlesource.com/external/webrtc/+/492c09fe59064c5d49f9110ed9c638a5f8a016b4

Patch Set 1 #

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -35 lines) Patch
M webrtc/voice_engine/test/auto_test/automated_mode.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/automated_mode.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fakes/conference_transport.h View 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fakes/conference_transport.cc View 2 chunks +20 lines, -16 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fakes/loudest_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/fakes/loudest_filter.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_conference_test.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.h View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 1 3 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kwiberg-webrtc
3 years, 8 months ago (2017-04-13 01:00:57 UTC) #4
kwiberg-webrtc
3 years, 8 months ago (2017-04-20 12:49:08 UTC) #7
the sun
On 2017/04/20 12:49:08, kwiberg-webrtc wrote: lgtm, but note that I'm working to remove this code.
3 years, 8 months ago (2017-04-20 14:35:14 UTC) #8
kwiberg-webrtc
On 2017/04/20 14:35:14, the sun wrote: > On 2017/04/20 12:49:08, kwiberg-webrtc wrote: > > lgtm, ...
3 years, 8 months ago (2017-04-20 19:43:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2813373002/40001
3 years, 8 months ago (2017-04-20 19:44:04 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 20:17:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/492c09fe59064c5d49f9110ed...

Powered by Google App Engine
This is Rietveld 408576698