ObjC: RTCVideoSource cleanup

ObjC: RTCVideoSource cleanup

RTCVideoSource was recently added in
https://codereview.webrtc.org/2745193002/. This CL addresses some post
commit feedback.

BUG=webrtc:7177
Review-Url: https://codereview.webrtc.org/2812533003
Cr-Commit-Position: refs/heads/master@{#17649}
Committed: https://chromium.googlesource.com/external/webrtc/+/24da37b0bf46b00f06b882809e9c595a1d0ed596

[magjed_webrtc, 2017-04-10 12:06:57]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 12:07:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2017-04-10 12:11:04]

Description was changed from

==========
ObjC: RTCVideoSource cleanup

RTCVideoSource was recently added in
https://codereview.webrtc.org/2745193002/. This CL addresses some post
commit feedback.

BUG=webrtc:7177
==========

to

==========
ObjC: RTCVideoSource cleanup

RTCVideoSource was recently added in
https://codereview.webrtc.org/2745193002/. This CL addresses some post
commit feedback.

BUG=webrtc:7177
==========

[magjed_webrtc, 2017-04-10 12:11:04]

magjed@webrtc.org changed reviewers:
+ denicija@webrtc.org, tkchin@webrtc.org

[magjed_webrtc, 2017-04-10 12:11:14]

Please take a look.

[commit-bot: I haz the power, 2017-04-10 14:07:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:07:41]

Dry run: Try jobs failed on following builders:
  win_baremetal on master.tryserver.webrtc (JOB_TIMED_OUT, build hasn't started
yet, builder probably lacks capacity)

[daniela-webrtc, 2017-04-11 08:10:08]

lgtm

https://codereview.webrtc.org/2812533003/diff/1/webrtc/sdk/objc/Framework/Hea...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h
(right):

https://codereview.webrtc.org/2812533003/diff/1/webrtc/sdk/objc/Framework/Hea...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h:47: */
Do we want to add compiler annotation as well?

- (RTCAVFoundationVideoSource *)avFoundationVideoSourceWithConstraints:
(nullable RTCMediaConstraints *)constraints __attribute__( (deprecated("Use -
(RTCVideoSource *)videoSource instead")));;

[magjed_webrtc, 2017-04-11 11:11:30]

https://codereview.webrtc.org/2812533003/diff/1/webrtc/sdk/objc/Framework/Hea...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h
(right):

https://codereview.webrtc.org/2812533003/diff/1/webrtc/sdk/objc/Framework/Hea...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h:47: */
On 2017/04/11 08:10:08, daniela-webrtc wrote:
> Do we want to add compiler annotation as well?
> 
> - (RTCAVFoundationVideoSource *)avFoundationVideoSourceWithConstraints:
> (nullable RTCMediaConstraints *)constraints __attribute__( (deprecated("Use -
> (RTCVideoSource *)videoSource instead")));;

That's probably a good idea to do in the future. On second thought, I think we
should wait with deprecating RTCAVFoundationVideoSource until we have tests for
the new RTCVideoSource+RTCCameraVideoCapturer and know it's working. When that's
done, we can deprecate RTCAVFoundationVideoSource properly and add the compiler
annotation and make an announcement to discuss-webrtc@googlegroups.com.

[magjed_webrtc, 2017-04-11 11:11:38]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2017-04-11 11:11:38]

The patchset sent to the CQ was uploaded after l-g-t-m from denicija@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2812533003/#ps20001 (title:
"Remove deprecation comment in RTCPeerConnectionFactory")

[commit-bot: I haz the power, 2017-04-11 11:11:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-11 11:50:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491909098441120,
"parent_rev": "29dbb1992a5722ab26bc7c0d4e17c0e91fe77c97", "commit_rev":
"24da37b0bf46b00f06b882809e9c595a1d0ed596"}

[commit-bot: I haz the power, 2017-04-11 11:50:18]

Description was changed from

==========
ObjC: RTCVideoSource cleanup

RTCVideoSource was recently added in
https://codereview.webrtc.org/2745193002/. This CL addresses some post
commit feedback.

BUG=webrtc:7177
==========

to

==========
ObjC: RTCVideoSource cleanup

RTCVideoSource was recently added in
https://codereview.webrtc.org/2745193002/. This CL addresses some post
commit feedback.

BUG=webrtc:7177

Review-Url: https://codereview.webrtc.org/2812533003
Cr-Commit-Position: refs/heads/master@{#17649}
Committed:
https://chromium.googlesource.com/external/webrtc/+/24da37b0bf46b00f06b882809...
==========

[commit-bot: I haz the power, 2017-04-11 11:50:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/24da37b0bf46b00f06b882809...