Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2812273002: Fix lint errors to enable stricter PyLint rules (Closed)

Created:
3 years, 8 months ago by kjellander_webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, AleBzk, peah-webrtc, zhuangzesen_agora.io, Andrew MacDonald, aleloi, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, mflodman, kwiberg-webrtc, minyue-webrtc, the sun, yujie_mao (webrtc), zhengzhonghou_agora.io, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix lint errors to enable stricter PyLint rules These fixes are needed to avoid errors after submitting https://codereview.webrtc.org/2737963003 BUG=webrtc:7303 NOTRY=True Review-Url: https://codereview.webrtc.org/2812273002 Cr-Commit-Position: refs/heads/master@{#17679} Committed: https://chromium.googlesource.com/external/webrtc/+/dd460e2aa2b7b8a9ad79d2b6a7945a2b7d301eaa

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -190 lines) Patch
M tools-webrtc/get_landmines.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools-webrtc/gtest-parallel-wrapper.py View 3 chunks +3 lines, -2 lines 0 comments Download
M tools-webrtc/ios/generate_licenses.py View 3 chunks +10 lines, -4 lines 0 comments Download
M tools-webrtc/vim/webrtc.ycm_extra_conf.py View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/audio/test/unittests/low_bandwidth_audio_test_test.py View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_gencfgs.py View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py View 1 2 chunks +5 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py View 10 chunks +29 lines, -29 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/plot_webrtc_test_logs.py View 5 chunks +14 lines, -14 lines 0 comments Download
M webrtc/tools/py_event_log_analyzer/misc.py View 6 chunks +9 lines, -9 lines 0 comments Download
M webrtc/tools/py_event_log_analyzer/misc_test.py View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/tools/py_event_log_analyzer/pb_parse.py View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/py_event_log_analyzer/rtp_analyzer.py View 14 chunks +33 lines, -33 lines 0 comments Download
M webrtc/tools/py_event_log_analyzer/rtp_analyzer_test.py View 2 chunks +11 lines, -12 lines 0 comments Download
M webrtc/tools/video_analysis_test.py View 3 chunks +12 lines, -12 lines 0 comments Download
M webrtc/video/full_stack_tests_plot.py View 16 chunks +43 lines, -43 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
kjellander_webrtc
aleloi@: webrtc/tools/py_event_log_analyzer alessiob@: webrtc/modules/audio_processing/test/py_quality_assessment henrika@: rubberstamp for webrtc/audio and webrtc/video/ (2 files)
3 years, 8 months ago (2017-04-12 14:05:40 UTC) #3
kjellander_webrtc
(forgot to add alessiob@ and henrika@ in last message)
3 years, 8 months ago (2017-04-12 14:06:10 UTC) #5
aleloi
py_event_log_analyzer LGTM
3 years, 8 months ago (2017-04-12 14:56:59 UTC) #6
AleBzk
lgtm py_quality_assessment
3 years, 8 months ago (2017-04-12 15:11:19 UTC) #7
kjellander_webrtc
Swapping henrika@ (OOO) for another root owner: niklas.enbom@
3 years, 8 months ago (2017-04-12 18:13:22 UTC) #9
kwiberg-webrtc
lgtm for webrtc/audio/ and webrtc/video/
3 years, 8 months ago (2017-04-12 18:46:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2812273002/1
3 years, 8 months ago (2017-04-12 18:51:01 UTC) #13
kjellander_webrtc
On 2017/04/12 18:46:08, kwiberg-webrtc wrote: > lgtm for webrtc/audio/ and webrtc/video/ Ah, thanks Karl!
3 years, 8 months ago (2017-04-12 18:51:06 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16099)
3 years, 8 months ago (2017-04-12 18:55:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2812273002/20001
3 years, 8 months ago (2017-04-12 19:03:20 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 19:06:20 UTC) #22
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/dd460e2aa2b7b8a9ad79d2b6a...

Powered by Google App Engine
This is Rietveld 408576698