Fixing bug that results in incorrect ICE role with ICE lite endpoints.

Fixing bug that results in incorrect ICE role with ICE lite endpoints.

There's some code that resets the ICE role on an ICE restart (behavior
that's specified in ICE, but removed from ICEbis). And it wasn't taking
into account that the remote endpoint may be an ICE lite endpoint, in
which case the WebRTC endpoint's role should always be "controlling".

BUG=chromium:710760
Review-Url: https://codereview.webrtc.org/2812173003
Cr-Commit-Position: refs/heads/master@{#17779}
Committed: https://chromium.googlesource.com/external/webrtc/+/897d08ef1b314e8d8fcd24d1dcfba820cb2501b7

[Taylor Brandstetter, 2017-04-12 21:15:30]

Description was changed from

==========
Fixing bug that results in incorrect ICE role with ICE lite endpoints.

There's some code that resets the ICE role on an ICE restart (behavior
that's specified in ICE, but removed from ICEbis). And it wasn't taking
into account that the remote endpoint may be an ICE lite endpoint.

BUG=chromium:710760
==========

to

==========
Fixing bug that results in incorrect ICE role with ICE lite endpoints.

There's some code that resets the ICE role on an ICE restart (behavior
that's specified in ICE, but removed from ICEbis). And it wasn't taking
into account that the remote endpoint may be an ICE lite endpoint, in
which case the WebRTC endpoint's role should always be "controlling".

BUG=chromium:710760
==========

[Taylor Brandstetter, 2017-04-12 21:16:26]

deadbeef@webrtc.org changed reviewers:
+ zhihuang@webrtc.org

[Taylor Brandstetter, 2017-04-12 21:16:26]

Zhi, since Peter is sick, could you take a look?

[Zhi Huang, 2017-04-12 21:32:59]

lgtm with a extreme minor suggestion.

https://codereview.webrtc.org/2812173003/diff/1/webrtc/p2p/base/transportcont...
File webrtc/p2p/base/transportcontroller.cc (right):

https://codereview.webrtc.org/2812173003/diff/1/webrtc/p2p/base/transportcont...
webrtc/p2p/base/transportcontroller.cc:607: // should always be controlling in
that case.
Extreme minor thing. Since we are changing the ice_role here, it feels more
straightforward by saying "Change the ICE role if the remote endpoint is not ICE
lite" or keeping the comment but change the code to ice_mode != ICEMODE_LITE.

[Taylor Brandstetter, 2017-04-20 07:23:54]

https://codereview.webrtc.org/2812173003/diff/1/webrtc/p2p/base/transportcont...
File webrtc/p2p/base/transportcontroller.cc (right):

https://codereview.webrtc.org/2812173003/diff/1/webrtc/p2p/base/transportcont...
webrtc/p2p/base/transportcontroller.cc:607: // should always be controlling in
that case.
On 2017/04/12 21:32:59, Zhi Huang wrote:
> Extreme minor thing. Since we are changing the ice_role here, it feels more
> straightforward by saying "Change the ICE role if the remote endpoint is not
ICE
> lite" or keeping the comment but change the code to ice_mode != ICEMODE_LITE.

Done.

[Taylor Brandstetter, 2017-04-20 07:24:00]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-04-20 07:24:00]

The patchset sent to the CQ was uploaded after l-g-t-m from zhihuang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2812173003/#ps20001 (title:
"Addressing Zhi's comment")

[commit-bot: I haz the power, 2017-04-20 07:24:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-20 07:57:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492673040018370,
"parent_rev": "f963dda877fbc5e2f81a7ef988472143aa76f782", "commit_rev":
"897d08ef1b314e8d8fcd24d1dcfba820cb2501b7"}

[commit-bot: I haz the power, 2017-04-20 07:57:28]

Description was changed from

==========
Fixing bug that results in incorrect ICE role with ICE lite endpoints.

There's some code that resets the ICE role on an ICE restart (behavior
that's specified in ICE, but removed from ICEbis). And it wasn't taking
into account that the remote endpoint may be an ICE lite endpoint, in
which case the WebRTC endpoint's role should always be "controlling".

BUG=chromium:710760
==========

to

==========
Fixing bug that results in incorrect ICE role with ICE lite endpoints.

There's some code that resets the ICE role on an ICE restart (behavior
that's specified in ICE, but removed from ICEbis). And it wasn't taking
into account that the remote endpoint may be an ICE lite endpoint, in
which case the WebRTC endpoint's role should always be "controlling".

BUG=chromium:710760

Review-Url: https://codereview.webrtc.org/2812173003
Cr-Commit-Position: refs/heads/master@{#17779}
Committed:
https://chromium.googlesource.com/external/webrtc/+/897d08ef1b314e8d8fcd24d1d...
==========

[commit-bot: I haz the power, 2017-04-20 07:57:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/897d08ef1b314e8d8fcd24d1d...