Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2811643006: Reconfigure capture session in a single transaction. (Closed)

Created:
3 years, 8 months ago by sakal
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reconfigure capture session in a single transaction. If we don't reconfigure capture session in a single transaction, RTCCameraPreviewView goes transparent when switching cameras. This is undesired behavior. BUG=webrtc:7177 Review-Url: https://codereview.webrtc.org/2811643006 Cr-Commit-Position: refs/heads/master@{#17664} Committed: https://chromium.googlesource.com/external/webrtc/+/844d2b9670857b5bc2be88d9199d54ca870dc4b2

Patch Set 1 : Reconfigure capture session in a single transaction. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/sdk/objc/Framework/Classes/RTCCameraVideoCapturer.m View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
sakal
PTAL
3 years, 8 months ago (2017-04-11 12:18:41 UTC) #4
magjed_webrtc
lgtm
3 years, 8 months ago (2017-04-11 12:21:34 UTC) #5
daniela-webrtc
lgtm
3 years, 8 months ago (2017-04-12 08:07:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2811643006/20001
3 years, 8 months ago (2017-04-12 08:07:53 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 08:27:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/844d2b9670857b5bc2be88d91...

Powered by Google App Engine
This is Rietveld 408576698